zulip / zulip-terminal

Official Zulip terminal client.
Apache License 2.0
661 stars 251 forks source link

Add Private Messages side panel #1197

Open neiljp opened 2 years ago

neiljp commented 2 years ago

This feature would provide the equivalent functionality to the web-app where clicking on the private messages button opens a drop-down.

However, in our case it seems cleaner (certainly as a first step) to integrate this as an alternative side panel to the streams/topics area. In this situation we likely need to add a key to switch back to the streams list, so may likely take over S for this purpose.

This issue comprises multiple steps, which could be resolved in one PR but may be more appropriate to merge over multiple PRs or cherry-picking commits from the one PR.

Possible steps:

There are various nuances to consider, such as preserving state in lists between toggling, whether we consider stream+topic as a state (ie. S returns to topic list if previously in it)

Possible followup would be to enable the p key for what I believe we currently do for P (needs checking), ie. go to next unread PM. That would involve focusing on the message list, rather than switching the left panel. We could also consider using s for 'next unread stream message' and enable a 'streams narrow' (no PMs). This is similar but subtly different to the existing n key (for next unread topic), a feature which needs a little fine tuning eg. #442. Except for perhaps the first of these, these follow-ups would definitely benefit from further discussion.

I most recently proposed this feature in #zulip-terminal > Streams/PMs view toggle #T1197, where discussion may continue.

plugyawn commented 2 years ago

@zulipbot claim

zulipbot commented 2 years ago

Hello @plugyawn, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

plugyawn commented 2 years ago

@zulipbot claim

zulipbot commented 2 years ago

Hello @plugyawn!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

plugyawn commented 2 years ago

@zulipbot claim

zulipbot commented 2 years ago

Hello @plugyawn!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.