TRACKING: Migrate internal code to use Direct Message terminology

neiljp commented 1 year ago

This is a follow-up to the user-visible #1288, as fixed by #1322.

Rename/clarify internal variables; we could dedicate a specific task to this, but it may be more effective to migrate as-needed, where one part of the code is changed at a time, which relates to a particular other change underway
Update to follow API changes; these will likely not be rapid, and support the older API for some time in any case

zulipbot commented 1 year ago

Hello @zulip/server-refactoring members, this issue was labeled with the "area: refactoring" label, so you may want to check it out!

abdulmoiz37 commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

Hello @abdulmoiz37!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

abdulmoiz37 commented 1 year ago

@zulipbot add "help wanted"

abdulmoiz37 commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot commented 1 year ago

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

abdulmoiz37 commented 1 year ago

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@zulipbot I would like to work on this issue as well till my other PR's get reviewed.can you assign this to me?

abdulmoiz37 commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

neiljp commented 1 year ago

@abdulmoiz37 You are welcome to work on this, but it's not a high priority compared to other areas.

As the summary aims to suggest, this may be better achieved by migrating naming when we work on particular areas, one at a time.

zulipbot commented 1 year ago

Hello @WladRamos, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot commented 1 year ago

Hello @WladRamos, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

mschuler10 commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

Welcome to Zulip, @mschuler10! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot commented 1 year ago

@PedroQXD You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

mschuler10 commented 1 year ago

@zulipbot abandon

PedroQXD commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

Welcome to Zulip, @PedroQXD! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

PedroQXD commented 1 year ago

Hello @neiljp , I was looking into this issue and I have a question. The issue description specifies that only the internal variables need to be renamed, but for this change, I believe it makes sense to also modify the methods headers. How should I proceed?

PedroQXD commented 1 year ago

@zulipbot claim

PedroQXD commented 1 year ago

@zulipbot abandon

WladRamos commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

ERROR: Unexpected response from GitHub API.

WladRamos commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

@WladRamos You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

Ajnus commented 1 month ago

@zulipbot claim

zulipbot commented 1 month ago

Welcome to Zulip, @Ajnus! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

Ajnus commented 3 days ago

(just to get to another issue here, still waiting the review)

@zulipbot abandon

Ajnus commented 3 days ago

(OK WE BACK 👺)

@zulipbot claim

zulip / zulip-terminal

TRACKING: Migrate internal code to use Direct Message terminology #1344