search

zulip / zulip-terminal

Official Zulip terminal client.
Apache License 2.0
628 stars 243 forks source link

Use "direct" as the message `type` when sending direct/private messages. #1388

Open laurynmm opened 1 year ago

laurynmm commented 1 year ago

Zulip servers (at API feature level 174) support "direct" as the preferred message type for direct/private messages when sending messages and sending typing notifications; see https://github.com/zulip/zulip/pull/25154.

For servers at this feature level, when sending direct messages (POST /messages), Zulip terminal should switch to using the new preferred "direct" value for direct messages.

For typing notifications, the default value was switched from "private" to "direct", so no changes need to be made by clients if the default is being used for direct/private message typing notifications.

See this #api design conversation for more context and discussion on the type parameter.

From that chat.zulip.org conversation related specifically to Zulip terminal:

@_Neil Pilgrim (neiljp)|2406 said:

From a ZT perspective, the post and get valid strings could be left different, or the same and loosened in advance. However, I'm thinking it may be cleaner to have a type which encompasses both, so it may make sense to hold off until the capability is introduced, given 7.0 will be backwards-compatible.

criticic commented 7 months ago

claim

0xUgochukwu commented 6 months ago

@zulipbot claim

zulipbot commented 6 months ago

Hello @0xUgochukwu!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.