search

zulip / zulip-terminal

Official Zulip terminal client.
Apache License 2.0
661 stars 251 forks source link

Search results should show recipient headers for every message #1550

Open neiljp opened 1 month ago

neiljp commented 1 month ago

Bug description

When searching (for text, our only option right now), it is possible to end up with results that show messages adjacently under the same heading (recipients, conversation).

This can be confusing, since these messages may be in the same conversation, but there may be messages between them that do not meet the search criteria (filter text), and it appears that the messages simply follow one another.

This was partially inspired by # design > Date indicators in search results.

How is the bug triggered?

How can you reproduce the bug?

Currently:

  1. Go to All messages view in ZT
  2. Search for the text (eg. /, 'date indicators', Enter)
  3. (Possibly scroll up/down to look for examples)
  4. Observe multiple conversations with adjacent messages under the same header line

Repeating in the web app shows each message with its own equivalent of our header line

A few examples with this search text are:

What did you expect to happen?

In the web client, this appears to be resolved by showing the recipient (conversation) header for every message in a search result.

While extra lines are at a premium in a terminal, we should show extra header lines a similar way, ie. showing the message recipient line above each message.

Note that it should not display the recipient part of the header in conversation views (specific DMs, topics), just like now, since the header information is in the part above that already.

We should also ensure the message line with the status/author/date, particularly the date, should always be shown - that is the default with the current code, except for two messages written to the same conversation within a narrow time window by the same sender. We should ensure the date appears in every message, when such messages are split by a recipient header, once this feature is implemented.

How are you running the application?

Please include as many of the following as possible:

Related future follow-ups

neoandmatrix commented 1 month ago

@zulipbot claim

zulipbot commented 1 month ago

Welcome to Zulip, @neoandmatrix! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

u7327620 commented 3 weeks ago

@zulipbot claim

zulipbot commented 3 weeks ago

Welcome to Zulip, @u7327620! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!