zulip / zulip-terminal

Official Zulip terminal client.
Apache License 2.0
666 stars 253 forks source link

Rendering issue with vertical columns including a specific shade of blue #1554

Open bcspragu opened 4 weeks ago

bcspragu commented 4 weeks ago

Bug description

Occasionally, a single vertical pane will be out of place in the UI. While writing this bug, I just realized that it seems to correlate 1:1 with the light blue color being used somewhere on that horizontal line. Specifically, the first time that shade of blue shows up on a line, everything to the right will have this 1 column shift.

Between the left panel and the center

2024-11-06_07-23-03

On the left edge of the help menu

2024-11-06_07-22-55

The one next to the blue horizontal line scrolls as the center pane moves, the others are generally fixed (because they come from something on the left side of the page

2024-11-06_07-21-10

How is the bug triggered?

How can you reproduce the bug?

  1. Open zulip-term

It occurs on every stock theme (they all use the same blue highlight) and in both Alacritty and xterm. This happens in both 256-color mode and 24-bit mode

What did you expect to happen?

Uninterrupted vertical lines.

How are you running the application?

Please include as many of the following as possible:

If possible, please provide details from the About menu: (hotkey: Meta + ?) (this can provide some of the details above)

This is probably for a separate bug report, but I can't open the About menu. Meta + m works for markdown, but neither of Meta + / and Meta + Shift + / trigger the About page for me.

2024-11-06_07-33-09

neiljp commented 4 weeks ago

Does this occur with the light blue color, or rather with a specific emoji, or channel/stream or topic which may have one in their name?

If so, this could be related to #333.

neiljp commented 4 weeks ago

Re the About popup, briefly:

It would be good to get to the bottom of this if possible - particularly since alt m appears to work! Alt/meta can be a challenging modifier at the best of times, at least until we have easily configurable keys.

Depending how you installed ZT, you can edit the keys config file in the source to try another key in the mean time.

bcspragu commented 4 weeks ago

Does this occur with the light blue color, or rather with a specific emoji, or channel/stream or topic which may have one in their name?

Ah, I think you might be onto something! All the light blues are from the same channel, and it does have emojis in its name, which don't render with the font I'm using (or any other fonts I tried while diagnosing this bug)

2024-11-06_20-30-59

Looking in the web UI, that emoji is 🧑‍💻, which is one of those combo emojis with a zero width joiner, specifically:

🧑 Person, Zero Width Joiner and 💻 Laptop.

It's likely the Zero Width Joiner causing problems here?

bcspragu commented 4 weeks ago

It would be good to get to the bottom of this if possible - particularly since alt m appears to work! Alt/meta can be a challenging modifier at the best of times, at least until we have easily configurable keys.

I should definitely have been more specific: I'm using Alt any time I said Meta in that previous message. Like you said, the actual Meta/Super/Windows key is what I use for my window manager, but I double checked my sxhkd keybindings and nothing is mapped to alt + ?, it's all Meta/Super/Windows