search

zulip / zulip-terminal

Official Zulip terminal client.
Apache License 2.0
640 stars 247 forks source link

Integrate Zulint into Zulip Terminal. #528

Open amanagr opened 4 years ago

amanagr commented 4 years ago

Zulip Terminal uses linters like isort, mypy, pep8 and pytest for running tests. Integrate all into Zulint and add it to Zulip Terminal.

preetmishra commented 4 years ago

@amanagr Great! I was going to bring this up in #zulip-terminal, my idea was to add a section in the README where we would explicitly encourage contributors to run isort, mypy, pycodestyle along with pytest locally before pushing their changes but Zulint seems more plausible. This will greatly help new contributors to make better commits.

neiljp commented 4 years ago

@amanagr I favour bringing zulint into the project, but at least initially my preference would be to use it for additional linting.

We could then discuss integrating it with the others later. I enjoy seeing different linting pass/fail in CI, and if zulint supports splitting linting elements up I feel that integration could be useful, though I'm not sure if including pytest fits.

This is related to #508 (meta-linters)

@preetmishra There is some text there regarding this, but if you have ideas of how to improve it, please discuss or propose a change :)

preetmishra commented 4 years ago

The text in the README is pretty descriptive already though I think it might be useful to add a redirect link to the README (or maybe add a section) in the message that @zulipbot comments whenever someone claims any issue for the first time.

zulipbot commented 4 years ago

Hello @amanagr, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

neiljp commented 3 years ago

This is being most recently worked on in #980.