Create additional (or update existing) themes

zulip / zulip-terminal

Official Zulip terminal client.

Apache License 2.0

642 stars 248 forks source link

Create additional (or update existing) themes #6

Closed amanagr closed 5 years ago

amanagr commented 6 years ago

Simply add your theme to ui.pallete to create a new theme. Previously added themes have become obsolete and they need to be updated. The default theme could also be improved.

DhruvThakker commented 6 years ago

I would like to work on this issue

sreshu commented 6 years ago

I would like to work on it too. Can anyone plz provide the communication channel for Zulip related queries??

amanagr commented 6 years ago

Hi @reshusinghhh, You can use https://chat.zulip.org/#narrow/stream/206-zulip-terminal to reach us. Also, the current blue and light theme are not updated with recent changes, they can be worked upon too.

AkshJain99 commented 6 years ago

@zulipbot claim

zulipbot commented 6 years ago

Welcome to Zulip, @AkshJain99! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

rht commented 5 years ago

I suppose adding major modern text editors colorscheme would be a start, e.g. onedark[1], gruvbox[2], or classic solarized.

[1] https://github.com/odedlaz/tmux-onedark-theme (https://github.com/joshdick/onedark.vim in vim) [2] https://github.com/egel/tmux-gruvbox

amanagr commented 5 years ago

Great idea @rht

neiljp commented 5 years ago

We now have sufficient themes to be going with; the issue is existing themes being out of date.

I have a branch which makes this clearer for end-users and in testing, to show which themes are good or may be incomplete.

Should we close this and add a new issue for updating existing themes?

timabbott commented 5 years ago

Yeah, that seems reasonable.

neiljp commented 5 years ago

OK, I'll do that once that branch is merged, so we can refer to it.

neiljp commented 5 years ago

With the merging of #251, which enables CI & run-time feedback of theme completeness, I'm closing this as discussed above, and will open another issue for updating/improving existing themes.