On removal of earlier messages, show elided sender/date fields of lower messages

zulip / zulip-terminal

Official Zulip terminal client.

Apache License 2.0

635 stars 245 forks source link

On removal of earlier messages, show elided sender/date fields of lower messages #833

Open neiljp opened 3 years ago

neiljp commented 3 years ago

To reproduce:

Compose a message in a stream with a new topic, and another one (or more) below it
Move the top messages to a different topic (edit the top message(s) only)
Note the sender and/or date fields may be missing in the remaining messages (not moved)

Note that while this can be triggered from within ZT, this can also be the case from the webapp, so the solution should work from the principle of handling events better.

update Feb 2024 This appears to still be present, though only reproducible in a narrow view.

mkp6781 commented 3 years ago

As I was trying to recreate this issue, I came across another bug as well. In ZT, I am able to edit content of a message on pressing 'e' even after the time to edit has expired. On sending the edited message, the content of the message does not change but it is labeled as 'edited' both in the webapp as well as ZT(NOTE: I have not changed the stream or topic). Is this the desired behaviour?

mkp6781 commented 3 years ago

@zulipbot claim

zulipbot commented 3 years ago

Hello @mkp6781!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

mkp6781 commented 3 years ago

@neiljp I have attempted to fix this bug my making changes to the update_rendered_view function. I can continue to fix the 2 failing tests. However, I was doubtful as to whether this is the right way to fix this issue. Should I rather try to make changes to handle_update_message_event.?

mkp6781 commented 3 years ago

@zulipbot remove "PR needs review"