search

zulip / zulip

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
https://zulip.com
Apache License 2.0
21.72k stars 7.94k forks source link

Settings → preview profile → close fails to go back to settings #22572

Closed andersk closed 2 years ago

andersk commented 2 years ago

If you open ⚙️ → Personal settings → Profile → Preview profile, the settings modal closes and the profile modal opens. If you then close the profile modal, we have some code that’s supposed to reopen the settings modal:

https://github.com/zulip/zulip/blob/768d7630af63da2cf8c7ae7bf079ab9f032e880c/static/js/settings_account.js#L721-L733

However, this was broken by 7a505e3857bbec1a8dd862da36e89b646dbe0115 (#20194), which migrated the profile modal to Micromodal.

Ideally, we should just open the profile modal on top of the open settings overlay (like we do for other modals like password and language), so there’s no need for that close/reopen dance.

Cc @ganpa3.

zulipbot commented 2 years ago

Hello @zulip/server-settings members, this issue was labeled with the "area: settings UI" label, so you may want to check it out!

ganpa3 commented 2 years ago

22588