Improve how names and statuses are shown

alya commented 2 years ago

Release-critical:

[ ] As discussed on CZO, when we are displaying user's status text, the status emoji to the left of that text, rather than to the right of the user's name. We should make this change for the user list in the right sidebar. Note that if the user has a status emoji but no status text set, the emoji should be shown to the right of the user's name, as it currently is.
[x] At present, when we show the user's status text, the user's name does not get abbreviated properly. This can be seen in the right sidebar and in the settings. We should fix this.

Screen Shot 2022-09-09 at 12 38 02 PM

[x] Long status messages without spaces in them spill out of the user profile modal. To be consistent with messages with spaces in them (which take up multiple lines), we should word-wrap such status messages using - at the end of the line. We should also keep the status text on the same line as the emoji.

Screen Shot 2022-09-09 at 1 08 03 PM

Not release-critical:

[x] Ideally, when a user has a status emoji, we would abbreviate long names earlier and show the emoji.

zulipbot commented 2 years ago

Hello @zulip/design, @zulip/server-sidebars members, this issue was labeled with the "area: right-sidebar", "UI experiment", "redesign" labels, so you may want to check it out!

alya commented 2 years ago

@amanagr Could you please pick up this one, so that we can finish polishing this release highlight feature? The first three points should probably take priority over everything other than work on the PMs section.

alya commented 2 years ago

@raghavluthra20 Do you have any partial work towards the points on this issue?

amanagr commented 2 years ago

Sure!

raghavluthra20 commented 2 years ago

@raghavluthra20 Do you have any partial work towards the points on this issue?

I think I might have some on the 2nd point but I need to clarify a bit more -> Does the screenshot mean to imply that the ellipsis should not be there in that case?

alya commented 2 years ago

For the second point, the ellipsis should be there. It's currently missing just in the "show status text" setting.

amanagr commented 2 years ago

I know the fix to these points, @raghavluthra20 you can open a PR if you have work on this. I will push on it.

raghavluthra20 commented 2 years ago

I know the fix to these points, @raghavluthra20 you can open a PR if you have work on this. I will push on it.

I don't seem to have any partial work that will be applicable at the moment.

timabbott commented 2 years ago

@amanagr sounds like you should take this from here.

zulipbot commented 2 years ago

@amanagr You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

amanagr commented 2 years ago

Another interesting use case of status text, which could look weird if the status emoji was in the next line:

alya commented 2 years ago

Hmm, it's interesting, but I'm not too worried about this example. Users can choose to put emoji anywhere they like in their status message, but this is not especially common, and they can move or remove the emoji if it looks odd to them.

amanagr commented 2 years ago

OK, I will open a PR for that, so we can test deploy. The checked the other 3 points, since they are fixed now, right?

alya commented 2 years ago

Yes, that sounds right, thanks!

timabbott commented 2 years ago

I removed the bug/release goal labels since the 2/3 tasks that were bugs as opposed to design changes that may or may not work out were merged.

alya commented 1 year ago

@amanagr Is there a PR that should be linked here as resolving the remaining point and closing the issue?

amanagr commented 1 year ago

I think I simply forgot about this. I can pick it up later on but for now, l think we should open it for others since I have a lot of tasks on my list.

Ujjawal3 commented 1 year ago

@zulipbot claim

Ujjawal3 commented 1 year ago

Unclaiming this issue so that I can start working on another issue. But will do changes requested in review.

Ujjawal3 commented 1 year ago

@zulipbot abandon

psankhe28 commented 1 year ago

Is this issue resolved? @alya

amanagr commented 1 year ago

It is being worked upon by @Ujjawal3 .

aa98-45556443355666 commented 1 year ago

@zulipbot claim

gantavya99 commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

Welcome to Zulip, @gantavya99! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

gantavya99 commented 1 year ago

@amanagr What part exactly of this issue is still remaining? So I can get started on that

alya commented 1 year ago

@gantavya99 There's a PR in "chat.zulip.org review" state for the only remaining part, so I suggest picking a different issue.

Nandini99-git commented 1 year ago

Hey @alya , I am interested to work on this for GSOC 2023. I am beginner to web but I am a fast learner, please guide me for GSOC .

alya commented 1 year ago

Hi @Nandini99-git please avoid leaving the same comment on several issues in the future, as it clutters up the discussion. We have a detailed guide on how to apply for GSoC with Zulip: https://zulip.readthedocs.io/en/latest/outreach/apply.html

Nandini99-git commented 1 year ago

Sorry for this

zulip / zulip

Improve how names and statuses are shown #22910

Release-critical:

Not release-critical: