zulip / zulip

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
https://zulip.com
Apache License 2.0
21.33k stars 7.74k forks source link

Make linkfiers reorderable #23716

Closed alya closed 1 year ago

alya commented 1 year ago

When there are overlapping linkifiers, it should ideally be possible to reorder them to determine which one will take priority (i.e., the one that's listed higher).

In the settings UI, can use the same drag-and-drop approach as we do for custom profile fields.

This addresses a user pain point (discussed on CZO):

Our users creating the linkifiers were under the impression that there is an matching order for the linkifiers and only the first match matters. They even went for the trouble of recreating the linkifiers many times so that they got the "order correct".

zulipbot commented 1 year ago

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

mpedro12 commented 1 year ago

hello I am interested in contributing to this issue.. for this particular issue, would it suffice to make the linkifier components drag and drop-able ?

mpedro12 commented 1 year ago

@zulipbot claim

alya commented 1 year ago

@mpedro12 No, the goal of this issue is that not only should they be drag-and-droppable, but their ordering should affect how the linkfiers are prioritized when a message is processed.

mpedro12 commented 1 year ago

@zulipbot abandon

ibrauf commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

Welcome to Zulip, @ibrauf! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot commented 1 year ago

@ibrauf You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

timabbott commented 1 year ago

Now that #23715 is complete, the remaining work for this is essentially just setting the database model + settings experience ... and then changing the line changed by the first commit of #23715 to sort by the the precedence field rather than the ID.

Ujjawal3 commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

@Ujjawal3 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

PIG208 commented 1 year ago

@zulipbot claim