search

zulip / zulip

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
https://zulip.com
Apache License 2.0
21.54k stars 7.81k forks source link

Add more external accounts with logos to the Zulip Cloud #26105

Open szabgab opened 1 year ago

szabgab commented 1 year ago

Now there are only two: GitHub and Twitter. It would be nice if some others could be added with their logos. e.g.

(Alternatively it would be nice if when we create a new custom profile field of an external account, we could also decide the logo, the appropriate (fa-* element) Just as GitHub has fa-github and Twitter has fa-twitter.

szabgab commented 1 year ago

If I am not mistaken there is a hard-coded list of default external accounts and the icons are defined here

If you think the request is reasonable, I can try to send a PR.

sbansal1999 commented 1 year ago

@zulipbot add "area: settings (user)" "needs discussion"

zulipbot commented 1 year ago

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (user)" label, so you may want to check it out!

sbansal1999 commented 1 year ago

Hey @szabgab thanks for the suggestion, I think adding the other external accounts definitely can be a neat addition to the User Profile.

I have started a discussion in CZO -- you can discuss the ideas with other folks and then can create a PR if you want.