search

zulip / zulip

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
https://zulip.com
Apache License 2.0
21.33k stars 7.74k forks source link

linkifier handle blocks selection #26798

Closed digama0 closed 1 year ago

digama0 commented 1 year ago

The linkifier reordering support from #26464 (thanks for that by the way!) currently makes the entire body of the linkifier a draggable item, which prevents being able to select/copy text from the linkifier itself (which I usually do when creating a new linkifier from an existing one). I suggest reducing the draggable region to just the patterned region on the left of the list item so that the rest can be selected as normal.

zulipbot commented 1 year ago

Hello @zulip/server-settings members, this issue was labeled with the "area: settings UI" label, so you may want to check it out!

laurynmm commented 1 year ago

@digama0 - Thanks for the feedback!

Mentioned this issue/comment in the Zulip development community discussion about reordering linkifiers so that folks who've been working on the linkifier organization settings UI see it: https://chat.zulip.org/#narrow/stream/6-frontend/topic/Reordering.20linkifiers/near/1644433.

kehshiba commented 1 year ago

@zulipbot claim

zulipbot commented 1 year ago

Hello @kehshiba!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

kehshiba commented 1 year ago

could i work on this @laurynmm

laurynmm commented 1 year ago

@digama0 - We were able to get a fix for this up and merged in https://github.com/zulip/zulip/pull/26806. It should be deployed to Zulip Cloud in the near future. Thanks again for the helpful feedback!