Open chrisbobbe opened 1 year ago
Hello @zulip/design members, this issue was labeled with the "design", "redesign" labels, so you may want to check it out!
If the implementation doesn't match the intended design (which is an open question), we should fix the implementation too.
From discussion: https://chat.zulip.org/#narrow/stream/101-design/topic/UI.20redesign.3A.20recipient.20bar.20colors/near/1673209
We should add regression tests for these functions in web/src/stream_color.js:
get_stream_privacy_icon_color
get_recipient_bar_color
To do that, let's first make a list of "base" stream colors to test as inputs, including:
stream_color_palette
list)Then call the functions on each of those and make a table, like:
get_recipient_bar_color
get_stream_privacy_icon_color
#94c849
#e4eed3
#94c849
#fae589
#f0ead6
#cbb85e
We'll hard-code that table in a test file. For the actual tests, we'll go through the table row by row and check that
get_stream_privacy_icon_color
andget_recipient_bar_color
give values that match the table.The tests should cover both light and dark mode.