zulip / zulip

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
https://zulip.com
Apache License 2.0
21.3k stars 7.71k forks source link

"New Login" email offers password reset for SAML users #30248

Open northrup opened 4 months ago

northrup commented 4 months ago

I would expect that when a user account is associated with an external authentication mechanism like SAML, that the "new login" security email would not offer them a link to reset their password in Zulip.

Zulip Server and web app version:

timabbott commented 3 months ago

Thanks for the report @northrup! This does indeed seem to be a quirk of the language, which is not conditional on what authentication methods are involved.

If you do not recognize this login, or think your account may have been compromised, please reset your password at {{ reset_link }} or contact us immediately at {{ support_email }}.

The best overall fix is to complete #17939 and the related cluster of work, such that we'd be able to just have a better recommendation for everyone on steps to take if they believe their account was compromised.

But I think we could close out this issue by changing the language to link to a /help/ guide on how to deal with a potentially compromised account, which can evolve over time as things like #17939 are completed.

zulipbot commented 3 months ago

Hello @zulip/server-authentication members, this issue was labeled with the "area: authentication" label, so you may want to check it out!