search

zulip / zulip

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
https://zulip.com
Apache License 2.0
21.19k stars 7.66k forks source link

Allow disabling outgoing webhook for a bot #31389

Open Pezhvak opened 3 weeks ago

Pezhvak commented 3 weeks ago

Since bot types cannot be changed after creation, and deletion is not easy, i recommend adding an special URL as disabled so we don't have to provide dummy URLs to receive a webhook which is not needed.

The problem is that some bots might need webhooks in future, considering limitations i had to create an outgoing webhook type of bot, but in this stage webhook is not needed but I'm forced to provide an URL.

I've pinpointed the file which is responsible for this: outgoing_webhook.py, my recommendation is to add an if statement to prevent calling the webhook if it's something like: http://disabled or https://disabled.

I can make the contribute if i get the approval on the idea.

alya commented 3 weeks ago

Thanks for the suggestion, @Pezhvak ! Posted here for discussion.

zulipbot commented 3 weeks ago

Hello @zulip/server-integrations members, this issue was labeled with the "area: integrations" label, so you may want to check it out!