zulip / zulip

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
https://zulip.com
Apache License 2.0
21.64k stars 7.88k forks source link

analytics: Add LoggingCountStat backend for messages read by client. #4099

Open rishig opened 7 years ago

rishig commented 7 years ago

We currently have a graph for messages sent by client, but it would also be interesting to know messages read by client, which in some sense is a better indicator of e.g. how people are using the mobile apps.

This will be a LoggingCountStat; you can see how active_users_log:is_bot:day is implemented to see how these work, and http://zulip.readthedocs.io/en/latest/analytics.html for general documentation on the analytics system.

The definition for analytics.lib.counts.count_stats_ should be the following:

    LoggingCountStat('messages_read_log:client:day', UserCount, CountStat.DAY)

The next steps are calling do_increment_logging_stat from an appropriate place in zerver/, and writing tests in analytics/tests/test_counts.py.

@PhoeniXkrypT, you might want to claim!

zulipbot commented 7 years ago

Hello @zulip/server-analytics members, this issue was labeled with the area: analytics label, so you may want to check it out!

PhoeniXkrypT commented 7 years ago

@zulipbot claim

zulipbot commented 7 years ago

Hello @PhoeniXkrypT, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for a week. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on this issue within 3 days, or else I'll automatically remove your assignment from this issue.

If you've decided to stop working on this issue, simply comment @zulipbot abandon to abandon this issue so someone else can claim it and continue from where you left off.

Thank you for your understanding and your valuable contributions to Zulip!

zulipbot commented 7 years ago

Hello @PhoeniXkrypT, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for a week. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 3 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

zulipbot commented 7 years ago

Hello @PhoeniXkrypT, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over ten days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

nkmishra1997 commented 6 years ago

@zulipbot claim

zulipbot commented 6 years ago

Hello @nkmishra1997, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

nkmishra1997 commented 6 years ago

@zulipbot claim

zulipbot commented 6 years ago

Hello @nkmishra1997, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!