Avoid false warnings for "have not referenced that issue in your commmit message".

zulip / zulipbot

GitHub workflow-optimizing bot by @zulip

Other

84 stars 65 forks source link

Avoid false warnings for "have not referenced that issue in your commmit message". #155

Closed showell closed 6 years ago

showell commented 6 years ago

See https://github.com/zulip/zulip/pull/9091 for context.

@timabbott merged my first three commits there (probably from his laptop) and closed the relevant issue that I mention in the description. But he left two commits to merge later (for context, it was right before a release, but as you know, he'll often merge just the first couple commits).

Later zulipbot gave me a warning that I haven't updated my commit messages with the relevant issues.

synicalsyntax commented 6 years ago

Looks like you still reference the issue in the pull request description but the rebased commits don't mention th issue. I think we can solve this by warning only if the issue is still open.