Closed garg3133 closed 3 years ago
Merging #192 (dac8044) into master (e23ff5c) will increase coverage by
0.22%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 41.44% 41.66% +0.22%
==========================================
Files 20 21 +1
Lines 596 600 +4
==========================================
+ Hits 247 250 +3
- Misses 349 350 +1
The unit tests needed to be updated for the last commit. Otherwise looks good, thanks!
The
number
parameter is deprecated in octokit/rest andissue_number
andpull_number
parameters are used now for all methods related toissues
andpulls
respectively.Also,
response.code
is deprecated in octokit promise response andresponse.status
is used now.Here's the error stack:
Fixed both the deprecations in this pull request.
Note: I used
issue_comment
parameter intemplate.getComments()
becuase issues api is being used in this method. https://github.com/zulip/zulipbot/blob/a68d0db8731d8d0357a28d470d96251d4fc5f037/src/structures/Template.js#L30