zulip / zulipbot

GitHub workflow-optimizing bot by @zulip

Other

84 stars 65 forks source link

test: Port tests to nock #208

Closed andersk closed 3 years ago

andersk commented 3 years ago

Mocking at the HTTP layer instead of the Octokit layer allows us to check that we’re using the Octokit API correctly and catch deprecation warnings.

codecov[bot] commented 3 years ago

Codecov Report

Merging #208 (a261a95) into main (c7d4dff) will decrease coverage by 0.32%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   56.69%   56.37%   -0.33%     
==========================================
  Files          24       24              
  Lines         612      612              
==========================================
- Hits          347      345       -2     
- Misses        265      267       +2