search

zuluhotelaustralia / zuluhotel

Zuluhotel for ModernUO
https://zuluhotel.com.au
GNU General Public License v2.0
10 stars 12 forks source link

Dockerfile optimized for development process, fixed error with CUE binary download #150

Closed it-sova closed 2 years ago

it-sova commented 2 years ago

A bit modified Dockerfile to match some best practices, pinned package versions and reordered steps - so after every change of the source code - you don't need to reinstall packages, cached layers will be used ( pretty useful for the local development )

As for cue helpers - it seems like this commit broke ExtractTarGz function ( at least - it is broken at that moment, an error occurs on the runtime stage - that's why CI/CD is green ), now server is able to download cue binary at startup and process all required files:

[21:41:12 INF] CUE Configuration is out of date, rebuilding via cli CUE cli is missing, downloading latest GitHub release ... cue export --force --outfile .zhcache.json Zuluhotel.cue ...  <s:Server.ZhConfig>
done; running cli ... [21:41:29 INF] Finished building CUE configuration. <s:Server.ZhConfig>
michaelwhelehan commented 2 years ago

@it-sova nicely done! :) just a heads up to click the "Re-request review" button after you make changes - I did it just now :)

it-sova commented 2 years ago

@it-sova nicely done! :) just a heads up to click the "Re-request review" button after you make changes - I did it just now :)

Thanks, I'm pretty unfamiliar with GitHub, was using Gitlab all the way :)