search

zumoshi / BrowserSelect

Browser Select is a utility to dynamically select the browser you want instead of just having one default for all links.
GNU General Public License v2.0
291 stars 39 forks source link

Protected URL in BrowserSelect is blocked by Outlook #28

Closed kchanlee closed 7 years ago

kchanlee commented 7 years ago

Environment

Repro steps

  1. Set BrowserSelect as my default browser
  2. Click a link from an email in Outlook
  3. BrowserSelect pops up
  4. Select a browser (Chrome or Firefox)
  5. The selected browser opens the URL, but it is blocked by Office 365: snipaste_20171020_110824

My opinion

Outlook sometimes rewrites/protectes URL in email (e.g. origin -> rewrited) for security reason. When I open the protected URL directly in the browser, it works. But when I open the protected URL in BrowserSelect and then choose a browser, it is blocked. Perhaps it is regarded as malware by outlook server.

zumoshi commented 7 years ago

hello, this seems weird to me that it works if you launch the browser directly but not through browserSelect. I have to ask, are you logged in into your live/office 365 account in the browser you selected?

also what happens if you right click->copy link and paste in the browser?

kchanlee commented 7 years ago

Hi @zumoshi ,

Yes, I have logged in.

If I right click -> copy link an paste in the browser, it works. And I found the difference: The original link that I copied is URL encoded:

https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.sample.com%2FManagementPortal%2FPendingActionsPage&data=02%7C01%7Csample%40sample.com%7C424d6cd5f6584daa1f1d08d517230393%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636440361499939299&sdata=WMGN8Je%2F40q6r+8JSGuA2lfabEmQzFM+Es1SdywsJng%3D&reserved=0

But the link after I select browser in BrowserSelect is URL decoded:

https://na01.safelinks.protection.outlook.com/?url=https://www.sample.com/ManagementPortal/PendingActionsPage&data=02|01|sample@sample.com|424d6cd5f6584daa1f1d08d517230393|72f988bf86f141af91ab2d7cd011db47|1|0|636440361499939299&sdata=WMGN8Je/40q6r+8JSGuA2lfabEmQzFM+Es1SdywsJng=&reserved=0

So I think it is probably the URL decoding in BrowserSelect that causes the issue.

zumoshi commented 7 years ago

nice find. please try with v1.3.8, I've fixed the unescaping of URL

JeffGillman commented 7 years ago

Nice job! Works as advertised with SafeLinks-encased URLs.

kchanlee commented 7 years ago

@zumoshi I've tried v1.3.8 and the issue is resolved. Thanks for the timely fix!