search

zumoshi / BrowserSelect

Browser Select is a utility to dynamically select the browser you want instead of just having one default for all links.
GNU General Public License v2.0
291 stars 39 forks source link

Added Chrome profile detection (closes #29) #38

Closed kueswol closed 6 years ago

kueswol commented 6 years ago

Added functionality to add Chrome profiles.

If Chrome browser is detected, we're searching for profiles. If any are found, we'll add the Chrome instances with the profiles and remove the default one.

zumoshi commented 6 years ago

hi, thanks for your work, just tested it. works nicely. there are just a few minor issues before I could merge it, which I can fix myself if you don't have the time.

  1. you didn't include Newtonsoft.Json.dll in installer.nsi, which means it won't be included in setup, and therefore the app won't run complaining about missing dll
  2. shortcuts for profiles are messed up. with 2, c, and ( opening chrome... it would be nice if the first letter of the profile's name was the third shortcut instead of open parenthesis.
  3. version needs to be bumped to 1.4.0
  4. if we're releasing a new version might as well fix #35

also would be nice if you could squash the commits so it's a single commit, and check the comments I made on the diff.

p.s. my first pull request! yay! the first time someone made a pull request on one of my projects

kueswol commented 6 years ago

I'll fix the stuff you've mentioned. Regarding you points:

  1. The dependency should be added by NuGet. I think when packaging the project NuGet should take care of it, doesn't it?
  2. Shortcuts will be fixed.
  3. I'll surely figure this out how to do it.
  4. I've never used Opera - haven't installed it either. If you won't mind, I'll let you take care of it.

yeah, the commit stuff was a bit messed up. First time actually working with GIT ;-)

p.s. congratulations! Don't worry, it's also my first time

zumoshi commented 6 years ago
  1. nope, nuget automatically downloads the dll when you run the app in visual studio, but unless we ask users to also use visual studio, nuget won't do that. I'm using NSIS to create the setup which is a 3rd party app unrelated to visual studio and nuget.
  2. right click project name -> properties -> assembly information.
  3. ok.

thanks again for what you've done so far.

kueswol commented 6 years ago

if I figured it out correctly, I'm supposed to do the changes with a new Pull Request, which means, we may close this one.

zumoshi commented 6 years ago

I'm pretty sure you could've just added the changes to this pull request. https://stackoverflow.com/a/9790530/1461004

but you've already made another one, oh well.