zumwald / oss-attribution-generator

utility to parse bower and npm packages used in a project and generate an attribution file to include in your product
MIT License
37 stars 23 forks source link

It seems to just stop? #5

Closed kkjdaniel closed 6 years ago

kkjdaniel commented 7 years ago

I run the command in my project, it quickly lists all the files its processing and then suddenly stalls and doesn't appear to continue.

Any help?

zumwald commented 7 years ago

How long are you noticing it stall for? If you're project is large, it can take a bit of time to traverse everything (minutes, in the case of an extremely large project I've seen).

Get Outlook for iOShttps://aka.ms/o0ukef


From: Karl Daniel notifications@github.com Sent: Thursday, July 27, 2017 5:26:17 AM To: zumwald/oss-attribution-generator Cc: Subscribed Subject: [zumwald/oss-attribution-generator] It seems to just stop? (#5)

I run the command in my project, it quickly lists all the files its processing and then suddenly stalls and doesn't appear to continue.

Any help?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzumwald%2Foss-attribution-generator%2Fissues%2F5&data=02%7C01%7Cdaniel.zumwalt%40microsoft.com%7Ca8ee2c86d20e4af243bb08d4d4eab038%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636367551818387948&sdata=PCnTztQcpVf8Vq7MylBFxEZQnjPdhVBcv9QVGE4kYVc%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACnCSEH2i1vfxAB9BtsDWMX4jOBP7bozks5sSIHogaJpZM4OlNb0&data=02%7C01%7Cdaniel.zumwalt%40microsoft.com%7Ca8ee2c86d20e4af243bb08d4d4eab038%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636367551818387948&sdata=YWiINb%2BkjRKF2LrHfG5b0gz4GTDr0U1l3PM2B%2BGYdC0%3D&reserved=0.

kkjdaniel commented 7 years ago

It appears to have stopped here and hasn't continued for about 10 minutes...

screen shot 2017-07-27 at 5 50 16 pm

EDIT: Going on 20 now, with no further output.

zumwald commented 7 years ago

@kkjdaniel can you share a gist with the symptomatic package.json?

kkjdaniel commented 7 years ago

@zumwald Here is a link... https://gist.github.com/kkjdaniel/acb9dd4c007b5f12bdceaab67d6564bc

kkjdaniel commented 7 years ago

@zumwald Any luck spotting what might be causing the issue?

zumwald commented 7 years ago

@kkjdaniel tried installing your package.json as-is and it errors due to your dependency on fs@* - is there a reason you're specifying a built-in module? My Node version is 6.10.3 and npm is at 3.10.10 (slightly lagging latest LTS, but not far off). I also noticed your dependencies contain a number of packages which appear to actually be devDependencies, it'd be helpful for you to keep those distinctions accurate for using this tool.

Here's the full repro steps in Powershell on Windows:

PS N:\repos> mkdir test

    Directory: N:\repos

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        8/16/2017   8:20 AM                test

PS N:\repos> cd .\test\
PS N:\repos\test> Get-Clipboard | Set-Content ./package.json
PS N:\repos\test> npm i
npm WARN deprecated retext-inspect@0.4.2: switch to unist-util-inspect for future development
npm ERR! Windows_NT 10.0.15063
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\dazumwal\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\
\npm-cli.js" "i"
npm ERR! node v6.10.3
npm ERR! npm  v3.10.10
npm ERR! code EREADFILE

npm ERR! Error extracting C:\Users\dazumwal\AppData\Roaming\npm-cache\fs\0.0.0\package.tgz archive: ENOENT: no such file
 or directory, open 'C:\Users\dazumwal\AppData\Roaming\npm-cache\fs\0.0.0\package.tgz'
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     N:\repos\test\npm-debug.log
PS N:\repos\test>
Kyle-Falconer commented 7 years ago

It's also hanging for me:

screen shot 2017-09-21 at 11 57 13 am

And all I have in the package.json's dependencies is:

    "dependencies": {
        "chai": "^3.5.0",
        "react": "15.4.2",
        "react-native": "0.42.3"
    }

This is happening both on Node v6.10 and Node v8.5.0 (I used nvm to switch to see if that was causing it).

Edit:

I tried isolating the package.json as mentioned in the previous comment and I can do the npm i step just fine, and when I do the attribution-generator, it still hangs at the same place. Moving chai to the devDependencies block makes no difference.

I trimmed my package.json file to the following, and the issue can still be reproduced:

{
    "name": "foo",
    "version": "1.0.0",
    "description": "foo",
    "main": "index.js",
    "author": "bar",
    "license": "ISC",
    "dependencies": {
        "react": "15.4.2"
    }
}

Edit 2:

It seems that it does eventually finish, but it takes hours to finish (I let it run for 3 hours and it finally did finish).

zumwald commented 7 years ago

I've noticed this too, perf is unacceptable. This, along with proper testing and CI/CD are on my radar to tackle before the holidays. I recognize that without the latter two, contributions are high-friction which makes this issue all the more painful for you @Kyle-Falconer.

pz325 commented 6 years ago

Just to follow up this thread:

Hangging for me at:

... processing wordwrap@0.0.2 processing wordwrap@0.0.3 processing wordwrap@1.0.0 processing wrappy@1.0.2 processing xmlbuilder@8.2.2 processing xtend@4.0.1 processing yargs@3.10.0 processing yauzl@2.4.1

zumwald commented 6 years ago

fixed in 1.6.0 thanks to @kconner and @rohithjidagam!