Revamp - Bugs #4

[zunath]

Tracking bugs found in revamp testing. New thread created as the old one was getting cluttered.

Bug ticket 1: https://github.com/zunath/SWLOR_NWN/issues/1130 Bug ticket 2: https://github.com/zunath/SWLOR_NWN/issues/1359 Bug ticket 3: https://github.com/zunath/SWLOR_NWN/issues/1380

[zunath]

It's possible to double search scavenge points. Click on one from an angle where you can't open it. Then move around and click again from when you can. Opening it will result in two search rolls with two chances to spawn contents - but still only XP based on the second roll.

[zunath]

Saberstaff can't be uncombined if you don't have the saberstaff perk.

Zun note: There's not an easy fix for this due to the way NWN works. Crossing it off as a wontfix for now, if a solution is found we can implement it.

[zunath]

The code in the attack roll that determines the character's facing uses their facing -before- the attack not their facing during it. If a character turns to attack, they will be treated as having their old facing for the purpose of backstab calculations. This is abusable.

[zunath]

Appearance editor is throwing this exception - something related to part 18. Could be an off by one error.

Exception type: System.Collections.Generic.KeyNotFoundException Message : The given key '18' was not present in the dictionary. Stacktrace: at System.Collections.Generic.Dictionary2.get_Item(TKey key) at SWLOR.Game.Server.Feature.GuiDefinition.ViewModel.AppearanceEditorViewModel.LoadBodyParts() in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Feature\GuiDefinition\ViewModel\AppearanceEditorViewModel.cs:line 451 at SWLOR.Game.Server.Feature.GuiDefinition.ViewModel.AppearanceEditorViewModel.Initialize(GuiPayloadBase initialPayload) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Feature\GuiDefinition\ViewModel\AppearanceEditorViewModel.cs:line 213 at SWLOR.Game.Server.Service.GuiService.GuiViewModelBase2.Bind(UInt32 player, Int32 windowToken, GuiRectangle initialGeometry, GuiWindowType type, GuiPayloadBase payload, UInt32 tetherObject) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Service\GuiService\GuiViewModelBase.cs:line 199 at SWLOR.Game.Server.Service.Gui.TogglePlayerWindow(UInt32 player, GuiWindowType type, GuiPayloadBase payload, UInt32 tetherObject) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Service\Gui.cs:line 326 at SWLOR.Game.Server.Feature.GuiDefinition.ViewModel.CharacterSheetViewModel.b__91_0() in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Feature\GuiDefinition\ViewModel\CharacterSheetViewModel.cs:line 236 at SWLOR.Game.Server.Service.Gui.HandleNuiEvents() in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Service\Gui.cs:line 230 at SWLOR.Game.Server.Core.Internal.RunScripts(String script) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Core\Internal.cs:line 133

[zunath]

Bug Report Targeting issue in space. System swapped my ship info with an NPC ship's details.

Bug Report can not dock while being targested but there is no one anywhere near me

[zunath]

Bug Report Hunters guild shop only sells bags, no equipment.

[zunath]

Bug Report The Dash ability icon is upside down.

Steps to Reproduce:

Open the Character window with 'C'.
Select Perks > General Perks.
Notice that the Dash icon is upside down.

[zunath]

Bug Report Using appearance 10032 [SWLOR] Magna Trooper changes the appearance to an invisible one. The camera cannot move once one's DM avatar is changed to this, as well. Changing to a different form fixes the camera bug. 10032 might need to be removed or fixed.

[zunath]

Bug Report When a player enters the pilot's seat, their double's HP doesn't line up. Iuyihpuru went to badly injured just now.

[zunath]

Bug Report Tier 1 laser miner not working on Idallia Asteroid outside of Hutlar

Bug Report Choosing asteroids of different kids, e.g. Tilarium asteroid makes them glow red, when trying to then use the qucikbar mining laser it says "Invalid Target"

[zunath]

Bug Report Registering ship on Viscara sends it to "CZ-220 Hangar"

[zunath]

Bug Report Pirate terror uses shield Hp repair on player

[zunath]

Bug Report Spawned ships do not fight. Pre-existing NPC's do not fight spawned ships. Tested with Mon Calamari Cruiser being spawned in and manually making NPC's fight. They sound like they're making attacks but otherwise nothing is happening.

Bug Report Pirate Terrors do fight each other when spawned in, previous bug regarding Mon Calamari Cruiser seems limited to it. However, when spawning in Pirate Terror and manually making it fight another Pirate Terror, they fight, but DM possession of one of them causes the combat to end and there's no way for the DM to make them fight while possessing one.

Bug Report Spawned creatures from the DM Creator with the faction of Commoner results in extremely passive NPC's that do not react to the world around them - they don't even fight back when being attacked. However, spawning a Hostile creature in the DMFI Custom Encounter area, setting it to Commoner, and spawning the custom encounter results in a properly working NPC.

Zun note: Need to ensure DM-spawned creatures get all scripts assigned.

[zunath]

Bug Report The Sith Troopers in [Prefab] Roche System - Nickel One - Verpine Starships Enterprise attack their own Sith Assault Droid. The Sith Assault droid does nothing. Seems to be a simple faction missmatch.

[zunath]

Add a check to ensure players are on 8193.34 or higher.

[zunath]

Bug Report ~~Lightsaber unique power to turn 2 sabers into saberstaff makes 2 Profiency 5 sabers become a Profiency 4 Saberstaff. Area Name~~

[zunath]

Bug Report As a DM, I am noticing non-functional color tags on player descriptions prior to their "Racial Type: " section of the description.

Zun note: This is a hold-over from Legacy. It's not something I'm going to fix - players can manually adjust their descriptions if it's a problem. The only other option is to wipe player descriptions and I think that's far more destructive than an unnecessary racial note on their description.

[zunath]

Bug Report If characters were migrated while encumbered, they will spawn in to the game encumbered regardless of what their new weight capacity is, and need to be re-encumbered then de-encumbered to fix this. Feya Delos spawned in with approx 40/150 carryweight and I had to spawn several dire maces in their inventory then take them away to fix the issue. Killing/resurrection did not work, nor did greater restoration.

Zun note: I logged in as Feya and the character was encumbered because the weight in their inventory was higher than their limit. Dropping items on the ground made me unencumbered. I don't think there's anything wrong here.

[zunath]

Bug Report Repairing ship can be skipped by unregistering the ship, then registering it again

[zunath]

Bug Report Crafted items sell for 1gp.

Zun note: Sell the items on the player market if you want more money. Won't be taking the time to update all pricing of items at this current time.

[zunath]

Various ship sizes need to be adjusted. https://discord.com/channels/484936923341651971/979184606827913297

Zun note: I don't really see an issue with the models used for the light escort or light freighter.

[zunath]

Bug Report Starship module/Weapons seems to have unlimited range

[zunath]

Bug Report When crafting, if you click manual craft and you don't have enough componants you usually get them back, however emeralds do not get returned.

[zunath]

Bug Report Training foils are plot items, if you mass craft them they cannot be removed.

Zun note: I think they mean undroppable, not plot.

Zun note: They did mean plot. This is intentional - I don't want training sabers in stores. To get rid of them, use the trash feature from the character menu.

[zunath]

Bug Report Crafted enhancements on items do not stack their effects.

[zunath]

Bug Report Logging out while in space and logging back in results in the ship controls still being in use.

[zunath]

Bug Report Put an capacitor Booster IV on a ship, boosting from 40 to 60 max Capacitor recharge only to 40 and not further

[zunath]

Bug Report The sight radius of most NPC's is extremely limited, and leads to one being able to pass close by to hostile mobs without being attacked. To clarify, this is for mobs like Tusken Raiders that have correctly functioning AI.

[zunath]

Bug Report Having crafted a Cot, a Bedroll, and a "Bench, Wood, Small" I have received no Fabrication experience for any of these things. Unable to progress in fabrication.

[zunath]

Bug Report Strong Style (Lightsaber) rank 5 retains the description (on the hotbar) of Rank 1. Unclear if it functions correctly.

[zunath]

Bug Report After gaining 300 skill points on this migrated character, I was only able to apply an additional 3 attribute points.

Bug Report After getting to SP 260/300 and getting what should be my 26th AP, my AP has gone to 30/30 with 1 remaining. Curiously, I cannot spend this AP on Might, but everything else is available.

Think this is just a totally bugged interface. If you poke me I might be able to find the screenshot.

Zun note: Something weird going on with AP calculations. Review and correct. https://discord.com/channels/484936923341651971/981040228036935771

[zunath]

Bug Report I can see everything on the map.

[zunath]

Bug Report Osk Moh'roli who sells you job information still says "Crystal" instead of Krystalle.

[zunath]

typo on the "Migration Info" board.

[zunath]

Bug Report Picked 50 Devices in my rebuild. Force user. Cant get devices. Doesn't appear in my skills list and I cant buy the perks, so that's working at least.

Probably don't want to let Force Users pick Devices and I presume non-force users could pick Force during their rebuilds.

[zunath]

Bug Report Seems the ui bugs out when you go from ship to land, my HP bar is stacked up all of saying i have 40 HP /40 like my ship when it also displays the normal amounts

[zunath]

Bug Report Wood, Fiberplast, Aluminum, and Scrap Metal do not stack.

[zunath]

Bug Report After five of the Qion Mutation Beasts spent some time spanking Kaz the server crashed, possibly from the spam of on-hit slow.

CrashRepro.zip

 NWNX Signal Handler:
==============================================================
 NWNX 8193.34 (9cfc0f5) has crashed. Fatal error: Segmentation fault (11).
 Please file a bug at https://github.com/nwnxee/unified/issues
==============================================================

  Backtrace:
    /nwn/nwnx/NWNX_Core.so(_ZN7NWNXLib8Platform13GetStackTraceB5cxx11Eh+0x3a) [0x7f3c9f397c0a]
    /nwn/nwnx/NWNX_Core.so(nwnx_signal_handler+0x87) [0x7f3c9f2eb1b7]
    /usr/share/dotnet/shared/Microsoft.NETCore.App/6.0.5/libcoreclr.so(+0x4dc9e1) [0x7f3c9c8be9e1]
    /lib/x86_64-linux-gnu/libpthread.so.0(<UNKNOWN>) [

0x7f3c9eee0730]
    ./nwserver-linux(_ZN16CNWCCMessageDataD2Ev+0x28) [0x5594a5e26598]
    /nwn/nwnx//NWNX_SWIG_DotNET.so(CSharp_NWNfNativefAPI_delete_CNWCCMessageData___+0x16) [0x7f3bebe41fa6]
    [0x7f3c274fddc6]
 NWNX Signal Handler:
==============================================================
 NWNX 8193.34 (9cfc0f5) has crashed. Fatal error: Segmentation fault (11).
 Please file a bug at https://github.com/nwnxee/unified/issues
==============================================================

  Backtrace:
    /nwn/nwnx/NWNX_Core.so(_ZN7NWNXLib8Platform13GetStackTraceB5cxx11Eh+0x3a) [0x7f3c9f397c0a]
    /nwn/nwnx/NWNX_Core.so(nwnx_signal_handler+0x87) [0x7f3c9f2eb1b7]
    /usr/share/dotnet/shared/Microsoft.NETCore.App/6.0.5/libcoreclr.so(+0x4dc9e1) [0x7f3c9c8be9e1]
    /lib/x86_64-linux-gnu/libpthread.so.0(<UNKNOWN>) [0x7f3c9eee0730]
    /lib/x86_64-linux-gnu/libc.so.6(abort+0x1fd) [0x7f3c9ed30611]
    /nwn/nwnx/NWNX_Core.so(nwnx_signal_handler+0x15d) [0x7f3c9f2eb28d]
    /usr/share/dotnet/shared/Microsoft.NETCore.App/6.0.5/libcoreclr.so(+0x4dc9e1) [0x7f3c9c8be9e1]
    /lib/x86_64-linux-gnu/libpthread.so.0(<UNKNOWN>) [0x7f3c9eee0730]
    ./nwserver-linux(_ZN16CNWCCMessageDataD2Ev+0x28) [0x5594a5e26598]
    /nwn/nwnx//NWNX_SWIG_DotNET.so(CSharp_NWNfNativefAPI_delete_CNWCCMessageData___+0x16) [0x7f3bebe41fa6]
    [0x7f3c274fddc6]

 NWNX Signal Handler:
==============================================================
 NWNX 8193.34 (9cfc0f5) has crashed. Fatal error: Segmentation fault (11).
 Please file a bug at https://github.com/nwnxee/unified/issues
==============================================================

  Backtrace:
    /nwn/nwnx/NWNX_Core.so(_ZN7NWNXLib8Platform13GetStackTraceB5cxx11Eh+0x3a) [0x7f0616422c0a]
    /nwn/nwnx/NWNX_Core.so(nwnx_signal_handler+0x87) [0x7f06163761b7]
    /usr/share/dotnet/shared/Microsoft.NETCore.App/6.0.5/libcoreclr.so(+0x4dc9e1) [0x7f06139499e1]
    /lib/x86_64-linux-gnu/libpthread.so.0(<UNKNOWN>) [0x7f0615f6b730]
    ./nwserver-linux(_ZN16CNWCCMessageDataD2Ev+0x28) [0x564205c65598]
    /nwn/nwnx//NWNX_SWIG_DotNET.so(CSharp_NWNfNativefAPI_delete_CNWCCMessageData___+0x16) [0x7f056325dfa6]
    [0x7f059e011a76]
 NWNX Signal Handler:
==============================================================
 NWNX 8193.34 (9cfc0f5) has crashed. Fatal error: Segmentation fault (11).
 Please file a bug at https://github.com/nwnxee/unified/issues
==============================================================

  Backtrace:
    /nwn/nwnx/NWNX_Core.so(_ZN7NWNXLib8Platform13GetStackTraceB5cxx11Eh+0x3a) [0x7f0616422c0a]
    /nwn/nwnx/NWNX_Core.so(nwnx_signal_handler+0x87) [0x7f06163761b7]
    /usr/share/dotnet/shared/Microsoft.NETCore.App/6.0.5/libcoreclr.so(+0x4dc9e1) [0x7f06139499e1]
    /lib/x86_64-linux-gnu/libpthread.so.0(<UNKNOWN>) [0x7f0615f6b730]
    /lib/x86_64-linux-gnu/libc.so.6(abort+0x1fd) [0x7f0615dbb611]
    /nwn/nwnx/NWNX_Core.so(nwnx_signal_handler+0x15d) [0x7f061637628d]
    /usr/share/dotnet/shared/Microsoft.NETCore.App/6.0.5/libcoreclr.so(+0x4dc9e1) [0x7f06139499e1]
    /lib/x86_64-linux-gnu/libpthread.so.0(<UNKNOWN>) [0x7f0615f6b730]
    ./nwserver-linux(_ZN16CNWCCMessageDataD2Ev+0x28) [0x564205c65598]
    /nwn/nwnx//NWNX_SWIG_DotNET.so(CSharp_NWNfNativefAPI_delete_CNWCCMessageData___+0x16) [0x7f056325dfa6]
    [0x7f059e011a76]

More notes:

Basically what happened is we were testing stuf out in pvp Dozens of fights happened without subudal on, all was well One fight I decide to try subdual Kill another player It crashed the server immediately As in, it said I damaged them, said they lost the effects of their buffs Didnt even say "So and so killed s and so" Just instant crash

we did test it against a mynock with 255 Vitality just to see if it's anything to do with NPC's with levels or DMG attribute items/skins on them, there was no server crash from that

[zunath]

Bug Report As a DM I cannot speak when I am possessing a creature. It doesn't matter if I simply Take Control or use Take Control Full Powers.

[zunath]

Bug Report Poison status effects from Korriban wildlife don't appear to ever fade away.

[zunath]

Bug Report /handonhip command does nothing.

[zunath]

Bug Report Dying in space while piloting a ship, and then respawning appears to result in respawning as the ship model, not the character model. This happened when I was DM killed so I could return to the hanger quickly by respawn. I had 50 piloting, 5 perks invested to pilot the ship, and I was piloting the Striker with no modifications.

[zunath]

Bug Report It rains during thunderstorms inside the Throne ship interior.

Bug Report Addendum to earlier bug report regardind rain inside the Throne,

It also rains inside the Hound. It might just rain inside all ships.

Bug Report The ship tilesets appear to have purple textures in strange places, and they're set to be outdoor areas and so weather and light chnages

[zunath]

Bug Report With a 24 DMG weapon and 24 Might, and 50 One-Handed skill, my Attack comes out at 132. Which is correct as per the Damage Calculation spreadsheet. The problem is I have Doublehand and Strong Style. The weapon DMG should be 24 plus 10, which makes me think the bonus DMG aspect of Strong Style doesn't work. Also, my 24 Might should be technically modified to 36 due to the 1.5x Calculation. It should mean that with Doublehand, my Attack should come out at 144, not 132. I don't know if something is broken with the Plus 10 DMG of rank 5 Strong Style, and with Doublehnad, but at the very least I dont see it change on the character sheet.

Zun note: Likely just a character sheet display issue.

[zunath]

Bug Report When clicking on the ship computer to access the navigation system, if you cancel the transition by stepping away from the terminal, you will be stuck as a ship and your PC will be there as an npc. Death does not give you back your PC model.

~~It seems to be fixable by going back to any computer terminal and loading into space, then loading back without interruption.~~

Method to replicate: be on any ship access piloting ship computer WSAD or click away immediately after clicking the clickable You are a ship.

Bug Report Coming back from being a ship results in your quickbar being wiped clean.

Not a game breaking bug, but a little annoying.

Zun note: Fairly confident this second bug is due to the first issue.

[zunath]

Bug Report Everytime a hostile player casts a spell or anything, it causes other players to instantly run and try to hit them.

Zun note: We do this to ensure NPCs aggro their attacker. We might want to exclude PCs from that command though.

[zunath]

Bug Report Combat Enhancement III appears to stack with itself.

[zunath]

Bug Report Dockhands on Korriban don't have shops attached to them. Probably not that big a deal. Other ones are working fine on Viscara/CZ-220.

[zunath]

Bug Report With a "Resource Harvester IV" bought from the Jawa merchant in Tattooine, I was able to harvest Raw Plagionite. Considering that to refine Raw Plagionite, you need Refining V as a perk, I am going to go on a limb and assume that it is a T5 resource And assuming that you need a T5 Harvester to harvest a T5 resource, then the "Resource Harvester IV" is actually a T5 harvester. Which means that the names of the harvesters are misleading and should be adjusted. Basic Resource Harvester should be "Resource Harvester 1" rather than not-numbered, so that sequential Resource Harvesters are properly numbered.

[zunath]

Bug Report Request - Would make sense to make Increase/Decrease Height output the currentl scaling (ex: 1.0 -> 1.1 -> 1.2) in the combat chat box for reference.