search

zunda / emoticommits

Commits and comments with emotions are good for your health :smile:
MIT License
5 stars 2 forks source link

Better to throttle query to github API #1

Closed zunda closed 11 years ago

zunda commented 11 years ago

In the near future, it would be good to have minimum interval between queries in lib/githubapi.rb

zunda commented 11 years ago

Done with ffcfa0d1c4bc8aa746267eb060ab094b47ec7618

zunda commented 11 years ago

$ time ruby scratch/record_activity.rb scratch/zunda.1.sqlite scratch/zunda.json with Throttle.new(1) real 0m2.189s user 0m0.244s sys 0m0.051s

with DummyThrottle.new(1) real 0m2.206s user 0m0.249s sys 0m0.051s

zunda commented 11 years ago

eb2691de8c156827624f226ff6d6048fe1564b8c

With 1 sec throttle:

real        79m41.343s
user        2m6.242s
sys 0m10.550s

WIth DummyThrottle:

real 70m3.085s user 2m5.927s sys 0m9.920s

For now, it might be better not to apply throttle ....