zuohui48 / pe

0 stars 0 forks source link

Unable to enter legal name with add command #1

Open zuohui48 opened 1 year ago

zuohui48 commented 1 year ago

Screenshot 2023-04-14 at 2.21.01 PM.png

I am unable to enter a valid Indian name which consist of S/O with the add command.

Steps to reproduce:

  1. enter "add n/John s/o Doe t/friend a/Sheares Hall p/1234567 t/basketball r/5" to command window
nus-se-bot commented 1 year ago

Team's Response

Thank you for raising this, however, the name feature is intentionally designed to prevent special characters, as almost all of them are by definition, invalid. Let us explain further.

We have given much thought into the design of our names and followed the "Name" class implementation of AB3 which similarly disallows special characters like "/" slashes in names.

The reason why we did not allow special names in "s/o" because allowing the special character "/" would allow actual invalid names like "bob ////// tom" which would be a larger feature flaw.

Furthermore, we belive this is more of a preference issue, to provide more convenience for users by allowing shortcuts. This is because "s/o" is short form for "son of" which is a valid input in name, hence users can still represent all of their full names in our address book, as seen below.

Screenshot 2023-04-17 at 6.54.05 PM.png

We appreciate your suggestion but we disagree this is a medium feature flaw, thank you.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi, I completely understand where you are coming from. I would agree if the use of special characters in names makes it difficult for the input to be parsed. However, disallowing s/o, which is part of a person's legal name, will cause inconvenience to the user as he is unable to enter his legal name. Below is the screenshot taken from the course website regarding the use of symbols in input values.

Screenshot 2023-04-20 at 10.46.45 PM.png

Thank you.