search

zuohui48 / pe

0 stars 0 forks source link

Invalid error message #2

Open zuohui48 opened 1 year ago

zuohui48 commented 1 year ago

Screenshot 2023-04-14 at 2.34.08 PM.png

The error message shown does not address the problem of the input. The problem with the input is the use of the word "TO" instead of "to", the error message indicates that the date entered is in valid format, which is not the case.

Steps to reproduce:

  1. enter "create-session n/Hall s/10-03-2022 10:00 TO 10-03-2022 11:00 l/MPSH2" in the command box.
nus-se-script commented 1 year ago

Team's Response

Thank you for bringing this to our attention.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Vague error message for datetime validation

Actual

When an incorrect date-time is added, it should specify why the date is incorrect.

Expected

Currently, the message is simply: Invalid Date Input Format (DD-MM-YYYY HH:mm). Please input valid digits.. Which is quite vague, and does not help the user in some instances.

Steps to reproduce

  1. Start the application
  2. Run the following command: create-session n/Test l/Test s/02-29-2023 09:00 to 03-30-2023 10:00

The error message shown does not specify why the date is incorrect, and can lead to unecessary confusion.

Screenshots

image.png

[original: nus-cs2103-AY2223S2/pe-interim#4403] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for bringing this to our attention.

This problem is planned to be fixed in a future version of SportSync, as described by Planned Enhancement #5 in our Developer Guide:

5. More error messages could be added to cover all possible invalid inputs.

When entering a wrongly formatted command, SportSync displays a generic message stating that the command format is wrong.

We plan on adding more error messages that precisely state how the command format is wrong, to improve user understanding.

e.g. “Wrong command format: Datetime should be in format DD-MM-YYYY HH:mm”

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]