zuramai / mazer

Free and Open-source Bootstrap 5 Admin Dashboard Template and Landing Page
http://zuramai.github.io/mazer
MIT License
2.77k stars 782 forks source link

Fix pagination item border radius issue after bootstrap upate #280

Closed Niksac closed 1 year ago

Niksac commented 1 year ago

Commit 809e8476 broke pagination styles due to changes in bootstraps SCSS.

New: image

Old: image

This happens because bootstrap adds border radius to each page link if it thinks the user intends to have margin between those elements:

  @if $pagination-margin-start == calc(#{$pagination-border-width} * -1) {
    ...
  } @else {
    // Add border-radius to all pageLinks in case they have left margin
    .page-link {
      @include border-radius(var(--#{$prefix}pagination-border-radius));
    }
  }

As the calc() is not executed on compile time, this comparison returns false for our value $pagination-margin-start: -$pagination-border-width !default;

Setting $pagination-margin-start to the same calc() expression on our end restores the look.

netlify[bot] commented 1 year ago

Deploy Preview for comforting-cocada-22086c ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/comforting-cocada-22086c/deploys/655e7a1401df1a7afc2f240d
Deploy Preview https://deploy-preview-280--comforting-cocada-22086c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zuramai commented 1 year ago

LGTM! Thank you