search

zurb / foundation-apps

The first front-end framework created for developing fully responsive web apps.
http://foundation.zurb.com/apps
MIT License
1.58k stars 216 forks source link

Newer angular version required when installing angular-cookies #694

Closed franbenz closed 8 years ago

franbenz commented 8 years ago

I tried to install the angular-cookies package with bower install angular-cookies. I got this prompt:

Unable to find a suitable version for angular, please choose one:
    1) angular#~1.3.4 which resolved to 1.3.18 and is required by foundation-apps#1.1.0
    2) angular#1.3.18 which resolved to 1.3.18 and is required by angular-animate#1.3.18
    3) angular#1.4.6 which resolved to 1.4.6 and is required by angular-cookies#1.4.6
    4) angular#>= 1.0.8 which resolved to 1.4.6 and is required by angular-ui-router#0.2.15

Does this means the foundation for apps project is fixed/stucked with an old angular version(~1.3.4) and I would break my project if I install a newer one?

gakimball commented 8 years ago

We haven't tested the framework on 1.4 yet, so stick with 1.3.x if you can. Although there's a decent chance it'll work with 1.4 right away.

kuatsure commented 8 years ago

@gakimball any movement on this issue? my team is also running in to an issue with the lower bound being 1.3.x ... it's the main hurdle for us to move our angular app to foundation-apps away from foundation-sites.

soumak77 commented 8 years ago

For what it's worth, I've been using F4A with angular 1.4.x in production code for a few months now. There were a couple problems I had to address in my own code due upgrading angular, but no issues were found in F4A.

kuatsure commented 8 years ago

@soumak77 how much of the angular modules do you use?

soumak77 commented 8 years ago

@kuatsure I use nearly every part of the F4A framework. It should also be noted that I run a custom build of the framework (https://github.com/fiboacademy/foundation-apps/tree/fibo-master). Some of my fixes/features have made there way into the F4A master and some haven't. The forked repo is set to angular 1.4.4, however, my build system is set to use angular 1.4.7 and I haven't noticed any issues.

gakimball commented 8 years ago

@soumak77 If you haven't seen any issues, we could introduce a range of 1.3.x to 1.4.x for the Angular dependency.

soumak77 commented 8 years ago

@gakimball that would be best

kuatsure commented 8 years ago

@gakimball + @soumak77 :: let's do that :) are pr's welcome?

gakimball commented 8 years ago

@kuatsure Yes! I want to sweep the recent pull requests soon.