search

zurb / foundation-apps

The first front-end framework created for developing fully responsive web apps.
http://foundation.zurb.com/apps
MIT License
1.58k stars 216 forks source link

Moved title into the ng-bind-html attribute. #710

Closed vincentpalita closed 8 years ago

vincentpalita commented 8 years ago

In order to be able to inject html in notifications I just moved the title variable inside the ng-bind-html directive. Please see https://github.com/zurb/foundation-apps/issues/692.

laurent-le-graverend commented 8 years ago

Not sure anyone would merge your PR soon or later @vincentpalita , this repo seems be dead.

In case of... you might probably also want to apply this logic to notification-static.html

vincentpalita commented 8 years ago

Hello,

Well the repo is not dead. I contacted them a few weeks ago and their team @zurb is really busy working on Foundation 6.

Moreover @gakimball tags all issue very fast. Let's all be positive!

Finally, both notification templates were modified in my pull request!

Cheers Vincent

laurent-le-graverend commented 8 years ago

Still, as a company who relies on a framework to work, it's not convenient to don't have any update for weeks while some many PRs are pending and are simple to integrate.

Regarding yours @vincentpalita, I didn't made it work with a ui router anchor URL, it might be related to $sce while getting a clean html string.

To me, the link would be more needed:

a/ As a full notification link (anywhere you click but the close button) b/ As html anchor(s) within the content

zurbrandon commented 8 years ago

@laurent-le-graverend Sorry about the lack of activity. We're still very committed to making Foundation for apps awesome! We're a little diostarcted with the next versions of Foundation for Sites and Emails, but are so amped and appreciative of the work you've been doing!