zurb / foundation-apps

The first front-end framework created for developing fully responsive web apps.
http://foundation.zurb.com/apps
MIT License
1.58k stars 216 forks source link

[ANNOUNCEMENT] Version 1.2.0 this Friday #725

Closed gakimball closed 8 years ago

gakimball commented 8 years ago

Hey guys, we're going to be releasing version 1.2.0 of Foundation for Apps on Friday. We'll be reviewing every issue and pull request this week, QAing on Thursday, and tagging a new release on Friday. If you have any thoughts on critical issues that need to be resolved, let us know!

gakimball commented 8 years ago

@soumak77 Thoughts?

austbot commented 8 years ago

Amazing Here are my suggestions. And I'm willing to help a bit. Not too critical.

soumak77 commented 8 years ago

I would love to see the following changes in 1.2. I've been using all these changes in production code for the past 6+ months. All changes to exposed APIs are backwards compatible:

Those have proven to be the most useful changes I've made to the framework. While I think PR #551 (Swipe Directives) is a really promising feature, there is much work to do still to get it working flawlessly, so I wouldn't suggest merging the PR for 1.2. I don't currently use those directives in production code, though I will need to for a product I have to release by September, so by then I'll have all the kinks worked out.

gakimball commented 8 years ago

@soumak77 Awesome, thank you! We plan on reviewing every PR before Friday. Are there any particular bugs that you think would be critical? (Granted, this isn't a one-and-done thing, we'll be doing more bug-fixing in the future. But this is our first patch in a while so we want to make it count.)

soumak77 commented 8 years ago

@gakimball There aren't any critical bugs that I've seen that I haven't already fixed myself in the framework. I think for the most part I've created PRs for things I've fixed in the framework along the way. I'll go through the changes I've committed to my company's forked repo of F4A that we use in production and reply shortly with the changes that haven't made it into the F4A master yet.

soumak77 commented 8 years ago

These are the only two bug fixes I've made that aren't yet in the framework:

soumak77 commented 8 years ago

In terms of existing issues, it would be nice to see the following resolved:

dexster commented 8 years ago

Would love to see this one fixed. Annoying that I have to handle animations manually when this is built-in

agianikas commented 8 years ago

Will this update include Angular 1.4?

gakimball commented 8 years ago

@agianikas Yes, we'll be testing in Angular 1.4. The bower.json will likely be a version range, to allow for 1.3 or 1.4.

zurbchris commented 8 years ago

@soumak77 in reference to fiboacademy@d6273a9 and #645, with the $timeout method you were still having errors if !scope or !element?

soumak77 commented 8 years ago

@zurbchris Please disregard my comments about that change. The head of my repo has the same code for modal destroy as F4A master and I haven't experienced any issues.

zurbchris commented 8 years ago

awesome

soumak77 commented 8 years ago

I would like to see https://github.com/zurb/foundation-apps/issues/572 resolved at some point as well. I ended up getting the functionality I needed, but my solution is a hack at best.

gakimball commented 8 years ago

We put out 1.2.0 on Friday. Thanks so much everyone for recommending bugs and pull requests for us to look at! The changelog includes an overview of our plans for 1.3, which will include a few deprecations, so be sure to take a look.

If there's anything that needs done for a patch to 1.2, let us know and we'll get to it. Thanks! :)