Closed gakimball closed 8 years ago
@soumak77 Thoughts?
Amazing Here are my suggestions. And I'm willing to help a bit. Not too critical.
I would love to see the following changes in 1.2. I've been using all these changes in production code for the past 6+ months. All changes to exposed APIs are backwards compatible:
FoundationMQ
service changesFoundationMQ
service have proven to be quite useful so that I can perform media queries in code as shown below. The methods use named queries so to allow user defined values.
FoundationMQ.matchesMediaOnly("small"); // checks if device is small only
FoundationMQ.matchesMedia("medium"); // checks if device is medium or higher
zf-interchange
.$q
service to handle the promises.foundationRoutes
when angular support is enabled. Uses the angular.module('foundation.dynamicRouting').config()
method to add routes.Those have proven to be the most useful changes I've made to the framework. While I think PR #551 (Swipe Directives) is a really promising feature, there is much work to do still to get it working flawlessly, so I wouldn't suggest merging the PR for 1.2. I don't currently use those directives in production code, though I will need to for a product I have to release by September, so by then I'll have all the kinks worked out.
@soumak77 Awesome, thank you! We plan on reviewing every PR before Friday. Are there any particular bugs that you think would be critical? (Granted, this isn't a one-and-done thing, we'll be doing more bug-fixing in the future. But this is our first patch in a while so we want to make it count.)
@gakimball There aren't any critical bugs that I've seen that I haven't already fixed myself in the framework. I think for the most part I've created PRs for things I've fixed in the framework along the way. I'll go through the changes I've committed to my company's forked repo of F4A that we use in production and reply shortly with the changes that haven't made it into the F4A master yet.
These are the only two bug fixes I've made that aren't yet in the framework:
In terms of existing issues, it would be nice to see the following resolved:
Modernizr
as I'm only using it for F4A support detection.Would love to see this one fixed. Annoying that I have to handle animations manually when this is built-in
Will this update include Angular 1.4?
@agianikas Yes, we'll be testing in Angular 1.4. The bower.json
will likely be a version range, to allow for 1.3 or 1.4.
@soumak77 in reference to fiboacademy@d6273a9 and #645, with the $timeout
method you were still having errors if !scope
or !element
?
@zurbchris Please disregard my comments about that change. The head of my repo has the same code for modal destroy as F4A master and I haven't experienced any issues.
awesome
I would like to see https://github.com/zurb/foundation-apps/issues/572 resolved at some point as well. I ended up getting the functionality I needed, but my solution is a hack at best.
We put out 1.2.0 on Friday. Thanks so much everyone for recommending bugs and pull requests for us to look at! The changelog includes an overview of our plans for 1.3, which will include a few deprecations, so be sure to take a look.
If there's anything that needs done for a patch to 1.2, let us know and we'll get to it. Thanks! :)
Hey guys, we're going to be releasing version 1.2.0 of Foundation for Apps on Friday. We'll be reviewing every issue and pull request this week, QAing on Thursday, and tagging a new release on Friday. If you have any thoughts on critical issues that need to be resolved, let us know!