search

zurb / joyride

jQuery feature tour plugin.
http://www.zurb.com/playground/jquery-joyride-feature-tour-plugin
1.42k stars 241 forks source link

[v3] Remove outline around box #210

Closed gakimball closed 8 years ago

gakimball commented 8 years ago

For mouse users, the outline around the box doesn't need to be there. This bit of CSS will disable the outline for mouse users only:

[data-whatinput='mouse'] .joyride {
  outline: 0;
}
Owlbertz commented 8 years ago

Indeed, would be great. I will add what-input to the dependencies.

gakimball commented 8 years ago

It might not need to be an explicit dependency—I noticed you don't list foundation-sites as a dependency, which makes sense because the plugin has a standalone bundle. It's more of an optional dependency.

From that perspective, would it make sense for it to not be an explicit dependency?

Owlbertz commented 8 years ago

I added it because it would be used in the Foundation based and in the standalone version. The same applies for jQuery.

Owlbertz commented 8 years ago

Closing because this was done with https://github.com/zurb/joyride/commit/19bb4f9d079260169eef83ea2003730b376f1f9a.