search

zurb / joyride

jQuery feature tour plugin.
http://www.zurb.com/playground/jquery-joyride-feature-tour-plugin
1.42k stars 240 forks source link

vertical position for the popup div #66

Open chaudhary opened 11 years ago

chaudhary commented 11 years ago

I am using jquery joyride and the vertical position is not being calculated for the popup div and as a result, vertical alignment of the div is not where it should be and the horizontal alignment is perfect.

mrsweaters commented 11 years ago

can you post an example?

avitus commented 11 years ago

I'm seeing a similar problem.

If I specify a tipLocation as left/right then a vertical position (top) is calculated but no horizontal position.

If I specify a tipLocation as top/bottom then a horizontal position (right) is calculated but no vertical position.

The result is that my tips are always glued to the left or top of my browser window. The demo works ok and I have the exact same configuration as the demo. The only difference is that I'm connecting to a data-id in my app.

chaudhary commented 11 years ago

I have fixed the problem. The problem is that outerHeight() function is not working fine in the joyride jquery file. So, we can replace it with outerHeight(false) and also, replace the outerWidth() by outerWidth(false).

avitus commented 11 years ago

Thanks, that fixed the problem.

I did a search and replace in the jquery.Joyride.js file and changed outerWidth() to outerWidth(false). I also had to change outerWidth(true) in two places to outerWidth(false).

Similarly for outerHeight.

WayneAtGC commented 10 years ago

This solves the issue for us as well.

alphabit commented 10 years ago

Just remove this code:

body { position: relative; }

from top of the joyride-2.1.css

ncri commented 10 years ago

We need the body to have position relative! How to get the joyride vertical positioning right? Any progress on this?

ncri commented 10 years ago

Ah, actually maybe we don't need that position relative... Just wondering why it is there?