search

zurb / orbit

454 stars 96 forks source link

Images with links have no captions #88

Closed aslamdoctor closed 12 years ago

aslamdoctor commented 12 years ago

I have 3 banners in slider & I have given links to all 3 banners. Now I tried to add the caption to all the Banners & it is not showing any captions. I tried giving "data-caption" tag to the anchor element but still its not loading. Also there is no error coming in Chrome debug tool. Can you please advise what should be the problem ?

Also I noticed one doubtful code in jquery.orbit-1.2.3.js file on line 201, it is as below

var _captionLocation = slides.eq(activeSlide).data('caption'); //get ID from rel tag on image

So here it should be "caption" or "data-caption", also the comments are saying something else here regarding rel tags of image :-S

aslamdoctor commented 12 years ago

sorry it was my mistake, i was using # tag in caption span element too, like this <span id="#myCaption".... so closing this issue :)