search

zurb / pizza

Better pie, donut, line, and bar graphs.
http://zurb.com/playground/pizza-amore-charts-and-graphs
MIT License
413 stars 65 forks source link

Supplying a data-text attr without percent or value causes a TypeError #13

Open Rainbowlemon opened 10 years ago

Rainbowlemon commented 10 years ago

screen shot 2014-03-11 at 11 10 58

Rainbowlemon commented 10 years ago

Related issue: '{{percent}}' parsing in data-text attribute should allow spaces or throw an error - currently, nothing happens if, for example, the data-text is '{{ percent }}'

Rainbowlemon commented 10 years ago

Also if {{value}} comes before {{percent}}, {{value}} isn't parsed correctly

mrsweaters commented 10 years ago

Does your pull request fix this issue?

Rainbowlemon commented 10 years ago

No, I thought it might warrant discussion so I left it out :) On 13 Mar 2014 18:20, "Jordan Humphreys" notifications@github.com wrote:

Does your pull request fix this issue?

Reply to this email directly or view it on GitHubhttps://github.com/zurb/pizza/issues/13#issuecomment-37568503 .