search

zurb / twentytwenty

jQuery Plugin to Compare Images
ISC License
1.27k stars 295 forks source link

Move slider on mouse hover #84

Closed daohoangson closed 7 years ago

daohoangson commented 7 years ago

Reimplement 7e2208e: add a move_slide_on_hover event that moves the slider handler during hover event, disabled by default.

raphaeleidus commented 7 years ago

if this is turned on for a touch device what will happen? should we force this feature off for users using touch devices

daohoangson commented 7 years ago

My bad, it looks like it doesn't work smoothly on touch browser. I will update the PR to disable itself when appropriate.

raphaeleidus commented 7 years ago

@daohoangson https://github.com/zurb/twentytwenty/pull/85 was just merged and it touches a lot of the same code that you were working on. I suggest you look it over and figure out how this can work with it. If you need some help, let me know

daohoangson commented 7 years ago

I haven't had time to update this PR for touch device yet. Will do in a few days, thank you for the heads up.

On Tue, Sep 12, 2017 at 1:27 AM, Raphael Eidus notifications@github.com wrote:

@daohoangson https://github.com/daohoangson #85 https://github.com/zurb/twentytwenty/pull/85 was just merged and it touches a lot of the same code that you were working on. I suggest you look it over and figure out how this can work with it. If you need some help, let me know

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zurb/twentytwenty/pull/84#issuecomment-328605543, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOm6K2KCfnkgZcRz3wBtg2MKeXGup0Dks5shXJTgaJpZM4PLSA2 .

daohoangson commented 7 years ago

@raphaeleidus I have merged #85 into this and they work beautifully together. The best way to use this now is probably with move_slider_on_hover = true and move_with_handle_only = false. Great UX on both desktop and mobile.