search

zurda / hangman-films

Hangman game: guess the film (movieDB API, Typescript, React)
https://hangman-films.netlify.app/
6 stars 6 forks source link

[Bug] Hint banner hides hints in the bottom section of the poster #37

Open zurda opened 3 years ago

zurda commented 3 years ago

When you click the poster hint, a small square of the poster is revealed.

If the revealed section is on the bottom of the poster, the user won't be able to see it.

We need to probably remove the hint banner so it doesn't hide the poster OR assure that the revealed poster section is not in the bottom section of the poster.

While both solutions solve the problem, the first one seems easier to maintain. I think the latter feels like adding unnecessary logic that will probably be confusing for people looking at the code.

Happy to discuss other solutions, if someone wants to suggest

Screenshot 2020-10-24 at 09 41 22
abhilash-ss commented 3 years ago

@zurda I also think the first option will be better. We can add the hint button below the Reveal Release Year button. What do you think? If it is fine I can add PR for this.

zurda commented 3 years ago

Sure thing @itsmeAB , feel free to pick this up thanks for offering to help!