search

zurda / hangman-films

Hangman game: guess the film (movieDB API, Typescript, React)
https://hangman-films.netlify.app/
6 stars 6 forks source link

fix: move hint button to below poster #37 #45

Open abhilash-ss opened 3 years ago

abhilash-ss commented 3 years ago
  1. added one more styled div PosterContainer which contains both hint button and the poster.
  2. update styles for HintButton.

@zurda please review the changes.

netlify[bot] commented 3 years ago

Deploy request for hangman-films accepted.

Accepted with commit 88dbd61c557abd4bdeef15c4d65a2f466e42611a

https://app.netlify.com/sites/hangman-films/deploys/5f9dc503f73a3e0007ae6a2f

zurda commented 3 years ago

Hi @itsmeAB , thanks for submitting this, and I appreciate the help!

One tiny thing, and I apologies for not specifiying this in the original ticket. Any chance we can keep the current design where the button and the poster container have no gaps between them? I think the current design is really nice.

this change adds a gap between the two elements, and I would love it if this issue could be fixed without changing the style, if that's ok Let me know what I think, I hope this makes sense?

abhilash-ss commented 3 years ago

@zurda no worries. will remove the space and submit PR.

abhilash-ss commented 3 years ago

Screenshot from 2020-11-01 01-58-41 @zurda It is the current screen with the spacing

it will look like this if I remove the spacing. Screenshot from 2020-11-01 02-03-41

What do you think? May need some more workaround.