search

zurfyx / angular-contents

Angular 5 Table of Contents that follows you while you scroll down
https://zurfyx.github.io/angular-contents
MIT License
40 stars 10 forks source link

Angular 7 Compatibility? #7

Closed lcborn4 closed 5 years ago

lcborn4 commented 5 years ago

I have been trying to ng update @angular/core and getting these errors:

          ```
Package "angular-contents" has an incompatible peer dependency to "@angular/common" (requires "^5.0.0" (extended), would install "7.2.9").
              Package "angular-contents" has an incompatible peer dependency to "@angular/core" (requires "^5.0.0" (extended), would install "7.2.9").
              Package "angular-contents" has an incompatible peer dependency to "rxjs" (requires "^5.5.2", would install "6.4.0").
zurfyx commented 5 years ago

Hi Icborn4,

It shows as a warning to me in a brand new Angular project (Angular CLI 7.3.5):

 > npm i angular-contents
npm WARN angular-contents@2.1.0 requires a peer of @angular/common@^5.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular-contents@2.1.0 requires a peer of @angular/core@^5.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angular-contents@2.1.0 requires a peer of rxjs@^5.5.2 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.7: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

+ angular-contents@2.1.0
added 1 package from 1 contributor and audited 42610 packages in 10.853s
found 0 vulnerabilities

Either way I commited v7 to support Angular 7 specifically as well as the RxJS 6 (otherwise rxjs-compat was needed). Please, let me know if you encounter any more issues.