zurichat / zc_main

A Workspace Web App powered by React and Node Js.

187 stars 866 forks source link

Fixed Modal Display and Sidebar Issues as Highlighted by David, HNG 9 Frontend PM for Zurichat #2850

Closed tryraisins closed 1 year ago

tryraisins commented 1 year ago

Fixes Issue/Linear Ticket

My PR Fixes The Modal Display and Sidebar Issues as Highlighted by David, HNG 9 Frontend PM for zurichat

Changes proposed

Resolve Z-index Conflicts, Sidebar Resize Issues and Sidebar Dropdown Menu not Closing when clicking Outside Element

What were you told to do?

Fix Edit Workspace Details Modal, Can't close modal after opening

What did you do?

Removed Z-index property in modalCon class in ModalComponentStyles.module.css Removed Z-index property in orgDiv class in Sidebar.module.css Reduced minimum width before sidebar automatically collapses in Sidebar.jsx Implemented useRef and added closemodal function in Header.jsx

Check List (Check all the applicable boxes)

🚨Please review the style guide for contributing and guidelines for contributing to this repository.

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.
[x] I am making a pull request against the dev branch (left side).
[x] My commit messages styles matches our requested structure.
[x] My code additions will fail neither code linting checks nor unit test.
[x] I am only making changes to files I was requested to.

Screenshots/ Videos

https://user-images.githubusercontent.com/78821732/207362777-1557d455-d463-41f3-a139-2e396fe65254.mp4