zurichat / zc_messaging

19 stars 88 forks source link

feat(BAC-52): added endpoint to view all files uploaded in DM #146

Closed NikkyXO closed 1 year ago

NikkyXO commented 1 year ago

these Screenshot no_file1 NoUploadedFile2

NoUploadedFile3

I have added documentation on how i wrote the end point for viewing an files in a room .However Adequate testing couldnt be achieved, especially the one involving getting input from the endpoint handling uploading of files The other colleague which this task was assigned couldnt finish up with his task, largely due to the fact that we were assigned our various tasks in less than 24 hours.. This was an error made by the product manager who gave us wrong repo with outdated codebase to study and refactor the implemenation of all endpoint relating to file upload in a room as we were mainly freelancers from other group and given the right repo in less than 24 hours when the mistake was realised

FlorenceEgwu commented 1 year ago

Good job! I have concerns your changes might not work as expected. kindly record a screen recording of your testing process

NikkyXO commented 1 year ago

good morning sir, i have made required changes to the end point and here is the required screen shot of the endpoint testings

The screenshots are as follows A screenshot was done while getting the message list and retrieving empty files no files where uploaded then because Uploading through the Upload file endpoint was unavailable as the task is unfinished by another, and the send messages endpoint kep giving 422 error, i used a dummy urlpath for testing the endpoint and helper zipfile file function screenshot was done while trying to retrieve and view archive files

the screenshots are attached below, thanks for your kind patience

yours sincerely olanike ogundiran [image: CheckingArchiveFile.png] [image: dummyurlpath.png][image: extract3.png][image: extractArchive.png][image: extractedArchive.png][image: list_of_files.png][image: List_of_uploaded_files.png]

On Sat, Nov 26, 2022 at 12:21 AM AI-fae @.***> wrote:

Good job! I have concerns your changes might not work as expected. kindly record a screen recording of your testing process

— Reply to this email directly, view it on GitHub https://github.com/zurichat/zc_messaging/pull/146#issuecomment-1327927691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXBO5XL6IP7LX2P5W7IDHPLWKFCZFANCNFSM6AAAAAASLA7YVM . You are receiving this because you were mentioned.Message ID: @.***>

NikkyXO commented 1 year ago

here is the link to the Pulll Request: https://github.com/zurichat/zc_messaging/pull/146

On Sat, Nov 26, 2022 at 7:13 AM olanike @.***> wrote:

good morning sir, i have made required changes to the end point and here is the required screen shot of the endpoint testings

The screenshots are as follows A screenshot was done while getting the message list and retrieving empty files no files where uploaded then because Uploading through the Upload file endpoint was unavailable as the task is unfinished by another, and the send messages endpoint kep giving 422 error, i used a dummy urlpath for testing the endpoint and helper zipfile file function screenshot was done while trying to retrieve and view archive files

the screenshots are attached below, thanks for your kind patience

yours sincerely olanike ogundiran [image: CheckingArchiveFile.png] [image: dummyurlpath.png][image: extract3.png][image: extractArchive.png][image: extractedArchive.png][image: list_of_files.png][image: List_of_uploaded_files.png]

On Sat, Nov 26, 2022 at 12:21 AM AI-fae @.***> wrote:

Good job! I have concerns your changes might not work as expected. kindly record a screen recording of your testing process

— Reply to this email directly, view it on GitHub https://github.com/zurichat/zc_messaging/pull/146#issuecomment-1327927691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXBO5XL6IP7LX2P5W7IDHPLWKFCZFANCNFSM6AAAAAASLA7YVM . You are receiving this because you were mentioned.Message ID: @.***>

NikkyXO commented 1 year ago

i unintentional made a git push -force from my branch while pushing to github , this closed the previous pull request i made here is the new pull request: https://github.com/zurichat/zc_messaging/pull/155

Apologies for the inconvenience yours sincerely olanike

On Sat, Nov 26, 2022 at 7:28 AM olanike @.***> wrote:

here is the link to the Pulll Request: https://github.com/zurichat/zc_messaging/pull/146

On Sat, Nov 26, 2022 at 7:13 AM olanike @.***> wrote:

good morning sir, i have made required changes to the end point and here is the required screen shot of the endpoint testings

The screenshots are as follows A screenshot was done while getting the message list and retrieving empty files no files where uploaded then because Uploading through the Upload file endpoint was unavailable as the task is unfinished by another, and the send messages endpoint kep giving 422 error, i used a dummy urlpath for testing the endpoint and helper zipfile file function screenshot was done while trying to retrieve and view archive files

the screenshots are attached below, thanks for your kind patience

yours sincerely olanike ogundiran [image: CheckingArchiveFile.png] [image: dummyurlpath.png][image: extract3.png][image: extractArchive.png][image: extractedArchive.png][image: list_of_files.png][image: List_of_uploaded_files.png]

On Sat, Nov 26, 2022 at 12:21 AM AI-fae @.***> wrote:

Good job! I have concerns your changes might not work as expected. kindly record a screen recording of your testing process

— Reply to this email directly, view it on GitHub https://github.com/zurichat/zc_messaging/pull/146#issuecomment-1327927691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXBO5XL6IP7LX2P5W7IDHPLWKFCZFANCNFSM6AAAAAASLA7YVM . You are receiving this because you were mentioned.Message ID: @.***>