search

zustandjs / zustand-slices

A slice utility for Zustand
MIT License
137 stars 6 forks source link

Refactor isDuplicated type #4

Closed grigorischristainas closed 2 months ago

grigorischristainas commented 2 months ago

Hey, nice project!

I open this pull request to refactor isDuplicated type, as I noticed that it is in fact used within HasDuplicatedNames to check for the presence of a Name in Names.

Hope I did not misunderstand its usage and that I am not breaking any additional functionality, but please let me know if any additional changes are required.

grigorischristainas commented 2 months ago

Committed a fix for the eslint error.

dai-shi commented 2 months ago

Hi, thanks for trying it out. I added some more tests.

grigorischristainas commented 2 months ago

Thank you, I will take another look within the week, otherwise I will close the pull request.

grigorischristainas commented 2 months ago

Gave it another try, just noticed another similar PR open that seems simpler :) Please feel free to close this one.

dai-shi commented 2 months ago

Yeah, thanks for trying anyway!