search

zwaldeck / mollie

Java framework to consume the Mollie API
Other
39 stars 36 forks source link

Library includes a dependency on an SLF4J implementation #1

Closed sgdesmet closed 5 years ago

sgdesmet commented 5 years ago

More an improvement suggestion than an actual issue:

This library includes a dependency on an SLF4j implementation log4j-slf4j-impl.

If someone uses this library and they already use their own SLF4j implementation - such as logback - the behaviour at runtime will be undefined and a random implementation is chosen. While a warning is shown, it is possible to miss this.

See https://www.slf4j.org/codes.html#multiple_bindings

zwaldeck commented 5 years ago

I added a scope tag in the pom file, so it's only used for test.

Should be good now

zwaldeck commented 5 years ago

This should be resolved