search

zwaldeck / mollie

Java framework to consume the Mollie API
Other
39 stars 36 forks source link

removed unirest dependency and replaced with JDK11 HttpClient #103

Closed paulvaneijden closed 10 months ago

zwaldeck commented 10 months ago

I still don't see the added value of removing UniRest for then to create basically a stripped down version of it but with some magic strings. I will keep Unirest in the lib as it has been proven that it's a stable library

paulvaneijden commented 10 months ago

What do you mean, still? You never indicated such a thing. In #73 you approved! The reason is simple: we don't use all the fluff that UniRest has, so adding (another) dependency is something you want to avoid. We discussed this beforehand, and you agreed: "Voor Unirest eruit te smijten en J11+ enkel te ondersteunen ben ik voorstander"

What do you mean with "magic strings"?