search

zwaldeck / mollie

Java framework to consume the Mollie API
Other
39 stars 37 forks source link

unirest dependency #31

Closed Aleph-Phi closed 4 years ago

Aleph-Phi commented 4 years ago

The unirest-java dependency is defined as provided but it is not a widely used rest client. It is also not documented so projects need to add this dependency in their own project.

It would be better to either make unirest-java scope compile. Projects can override this dependency if they need a different version.

<dependency>
    <groupId>com.konghq</groupId>
    <artifactId>unirest-java</artifactId>
    <version>2.3.11</version>
    <scope>provided</scope>
</dependency>
Elvynia commented 4 years ago

@Aleph-Phi Thank you for stating this issue ! :)

zwaldeck commented 4 years ago

You are correct.

Will update this one soon

zwaldeck commented 4 years ago

Updated the version and scope of the dependency