search

zwaldeck / mollie

Java framework to consume the Mollie API
Other
39 stars 36 forks source link

support adding GET queryParams using Builder objects, so it's more line with POST objects #74

Closed paulvaneijden closed 2 years ago

paulvaneijden commented 2 years ago

This is an invitation to severely comment on this PoC before we roll it out to other methods

zwaldeck commented 2 years ago

Is this feature not a bit over engineering with reflection and all?

This makes sense if a lot of endpoints start to have a lot of query params, but at the moment most endpoint only accept a few query params.

So for a user standpoint it's easy enough to use Map.of() to send the query params to mollie.

I understand what you are trying to do, but I think is complexity the library does not need yet.