Incorrect typeCode for gnre atom

[GoogleCodeExporter]

mp4v2 write "0x12" (genres) in the gnre atom typeCode. But iTunes wants "0x00" 
(implicit). It does not display the genre if the typeCode is "genres".
I guess iTunes is doing the right thing, because Apple wrote it. Atomic Parsley 
uses implicit as typeCode too.

Original issue reported on code.google.com by damiog on 3 Nov 2010 at 7:37

Attachments:

• gnre.diff

[GoogleCodeExporter]

Hrm.  Maybe Kona can comment on this one as he's more familiar with the 
existing standards; what does "implicit" mean?

Original comment by kid...@gmail.com on 29 Jan 2011 at 4:22

[GoogleCodeExporter]

The spec says implicit is "for use with tags for which no type needs to be 
indicated because only one type is allowed".

But it's not clear if you must use implicit in these situations and iirc iTunes 
and other software are not consistent in this regard. iTunes is pervasive so if 
it needs implicit, that is compatible with mp4v2's reader as Tags::fetchGenre() 
doesn't even inspect typeCode.

On a side note, many other tags must be integer type yet no issues there. Silly 
that iTunes insists it must be implict, which is then hardcoded to interpret as 
genres anyways.

Attached is an untested one-liner that should do the trick.

Original comment by Kona8l...@gmail.com on 29 Jan 2011 at 8:13

Attachments:

• gnre_01.patch

[GoogleCodeExporter]

Should be fixed in r444.  Closing issue.

Original comment by kid...@gmail.com on 31 Jan 2011 at 4:43

• Changed state: Fixed