Add/Edit SmartStart provisioning list

marcelveldt commented 1 year ago

From core created by AlCalzone: home-assistant/core#94067

The problem

A controller providing control of the SmartStart functionality MUST:

[x] Provide a method for the end user to view the Node Provisioning List entries with their network status (included/ not included or failed) --> double check!
[x] Provide a method for the end user to manually add and remove entries in the Node Provisioning List.
[ ] Provide a method for the end user to edit available settings for each entry in the Node Provisioning List. (e.g., Inclusion setting, Advanced joining)
[x] Support S2 inclusion with authentication using the DSK PIN code.
[x] If a user removes a node from the Node Provisioning List and the node is still included in the Z-Wave network, the controller MUST inform the end user that the node will stay in the network and requires to be excluded manually or reset to factory default in order to leave the Z-Wave Network.
[x] A controller MUST inform the end user that S2 only (non-SmartStart) nodes present in the Provisioning List require to perform a classic inclusion to add them into the Z-Wave network. Problem avoided, see comments below

Currently there's no such UI in Home Assistant.

[ ] When done, this also needs to be added to the documentation/manual.

Advanced joining = selecting which keys shall be granted (optional)

What version of Home Assistant Core has the issue?

core-2023.7.0.dev20230605

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

marcelveldt commented 1 year ago

Why would there be non SmartStart devices in the provisoning list? That sounds useless.

I don't think this makes sense, but we have already solved it I think? When you scan a QR code that belongs to a non-smartstart device, it instructs you to do a normal inclusion. At least I remember talking about this with Raman.

marcelveldt commented 1 year ago

The original issue from core (where this issue is migrated from) had a few comments. The gist is that we do not need any new functionality to add non smartstart devices as the Ui already points the user to do a regular inclusion.

AlCalzone commented 5 months ago

It seems that most of this is done. I'm not 100% sure that this is also solved

Provide a method for the end user to edit available settings for each entry in the Node Provisioning List. (e.g., Inclusion setting, Advanced joining). A controller application MAY provide no available settings.

...since there is no way to edit the settings, but the certification test still passed although I selected it is not possible. Would be nice to have though.

MartinHjelmare commented 2 months ago

What's the status here?

AlCalzone commented 2 months ago

It would be nice to be able to edit the existing provisioning entries - deselecting security classes, possibly switching from Mesh to LR, predefining name and location (?). Not required for certification though.

zwave-js / certification-backlog