Fix service call for setting a config value

zwave-js / certification-backlog

Issues and discussions related to Z-Wave certification of HA + Z-Wave JS

1 stars 0 forks source link

Fix service call for setting a config value #12

Open marcelveldt opened 1 year ago

marcelveldt commented 1 year ago

AlCalzone commented 12 months ago

Also, resetting all config parameters (and optionally, individual ones) to default must be supported.

This is not supported yet

AlCalzone commented 12 months ago

Refreshing such a config parameter seems also not supported, this is not a requirement though.

marcelveldt commented 12 months ago

This task has been split up into multiple smaller ones. Left is fixing the set config value service call.

raman325 commented 12 months ago

@AlCalzone according to the typing here: https://github.com/zwave-js/node-zwave-js/blob/master/packages/cc/src/cc/ConfigurationCC.ts#L107

valueFormat is required alongside valueSize. Is that correct? If so then this behavior is correct and should be expected. If not, then should we update the type? This will need to be fixed in the server and lib as well

AlCalzone commented 10 months ago

Hmm, you're right. I could have sworn it defaults to signed. In this case it's just the error message that's terrible.

raman325 commented 10 months ago

Yeah unfortunately that comes from the validator we use. I'll look into customizing the message

marcelveldt commented 4 months ago

This is a candidate for the expert UI

AlCalzone commented 2 months ago

[ ] Figure out if we can move the service call for setting custom config parameter into the expert UI
[ ] Make it impossible to provide incomplete/invalid combinations of options. Allowed:
1. parameter + value
2. parameter + bitmask + value
3. parameter + value + value size + value format
[ ] Figure out if points 1 and 2 should even be supported. They should have corresponding values that can just be set directly.

MartinHjelmare commented 2 months ago

I think we should first fix the service call. Then we can do the rest. We can't remove the service call, if we even want that, without a long deprecation time anyway.

The service to be fixed is named zwave_js.set_config_parameter.

MindFreeze commented 2 weeks ago

The fixed service will merged with https://github.com/home-assistant/core/pull/129332

MindFreeze commented 6 days ago

Maybe we can close this issue. The service validation has been removed. A new UI for custom params is added in #31 but in the node config page, not the expert UI. Is there anything else to do here? Maybe tweak the validation?

AlCalzone commented 5 days ago

I'll double check that it works as intended, then close 👍🏻